~ knotless Search/
↑↓ move↵ open⇧↵ all results

grain.social/grain

photography-focused photo sharing platform

grain.social
1 collaborator
0
2

Checks run on pulls into feature branches

Merged
Merged chadtmiller.com asked to merge into feature/rust from grain.social/grain:ci/feature-branches

What changes

CI. check and test run on pulls into feature/* as well as into main, as knotless's do. Deploy, mirror and lexicon publishing still run only on pushes to main, so nothing deploys from a feature branch.

AGENTS.md gets "Landing a change", after knotless's: build and test on the runner rather than locally, pulls through knotless following .knotless/pull.md, review.knotless.dev's reviews, nothing onto main without the owner's word, and how a feature branch is worked (pulls into it, one unqueued pull from it into main, main merged in as it moves).

Why

The move off hatk is built on feature/rust as a series of reviewed, checked pulls. Without this, a pull into the feature branch runs no checks at all.

How it was checked

This pull is the first test of it: its own check and test should run, since it is a pull into feature/rust with the new bases. Nothing was run locally.

Shortcomings

The same change on main, so every feature branch gets it, is left for when this branch lands.

🤖 Generated with Claude Code

chadtmiller.com added 2 commits
Approved

This adds refs/heads/feature/* to the pull bases of check.yml and test.yml. Push triggers stay on main, so deploy, mirror and lexicon publishing are unchanged. It also adds a "Landing a change" section to AGENTS.md. The edits are small and match the description. I found nothing that needs to change.

I didn't check the checks on this pull. Whether check and test actually run on it is the test of the glob.

Merged as da30a83
Part of a stack of 2
  1. Checks run on pulls into feature branches Landed as da30a83
  2. main