{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza3zzrrcfku","kind":"pull","title":"Spaces are read and written from grain's core, tested on the alpha","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T05:42:50.545Z","comments":2},"body":"## What changes\n\n**`grain::space`**, the core that private galleries and groups' pools are built on, after knotless's `space.rs`: a space's URI (`at:///space//`) and its parts; a credential to read one, made from a delegation token the reader's own PDS signs (`getDelegationToken`) and exchanged at the authority's PDS (`getSpaceCredential`) for a credential bound to a fresh P-256 key, each request signed for the repo it is addressed to (RFC 9421, as the alpha signs it); reading a repo's records (`listRecords`, every page), the space's writers (`listRepos`, credential only, as zds serves it) and a blob (`getBlob`) with it; the spaces an account's PDS lists (`listSpaces`, filtered by `spaceType` and pds.js's `type`); and `Admin`, what an account does with its own session: create a space with the memberspace policy, put a member to read or to read and write, list members, `applyWrites`, `putRecord`, `deleteRecord` and read its own repo there. `denied` and `not_served` tell an authority's no from a PDS with no such method.\n\n**`grain::auth::verify_delegation`** checks a delegation token as knotless's does (its type, that it names the space's authority's PDS, the reader's signature), for an app to prove a reader with in a later pull.\n\n**The tests of spaces run on the spaces alpha.** `harness/pds.mjs` runs the dev-env `GRAIN_DEV_ENV` names, and says `spaces: true` for one on the alpha; `harness/cov.mjs` runs the test binaries named `spaces` against one such harness and the rest against the npm PDS as before; `harness.yml` builds the alpha from atproto commit `11c5d98` (the one knotless's tests use) and caches it in `/opt/atproto`. AGENTS.md says how.\n\n## Why\n\nThe first of the stack porting private galleries and groups' pools off the old server. Every read or write of a space goes through what is here, so it comes first and alone.\n\nThe old server read the same way, but through its framework; it is copied from knotless's Rust, with grain's fallback to `com.atproto.simplespace.*` (pds.js, zds) kept: the reference names are asked first and the older ones when the PDS answers 404 or 501, in the shapes the old server's `server/spaces/client.ts` sent (`did` named, the policy a bare string in a nested `config`).\n\nThe alpha is built from a commit rather than installed from npm because npm's `0.0.0-spaces-alpha-*` builds name their dependencies `workspace:`, so they do not install (bun says so; npm exits 1 silently).\n\n## How it was checked\n\n`crates/grain/tests/spaces.rs`, against the alpha built locally from `11c5d98`: a private gallery made and written with `applyWrites`, a reader put on it, its members listed, its blob read back by the reader with a credential, the owner finding it in `listSpaces`, an outsider refused at the exchange (`denied`), and a real delegation token verified; a pool made by a stand-in group, a member writing and deleting their own records there, the group reading them with a credential and listing its writers, an outsider's write kept by their own PDS but never listed as the space's, and the outsider refused. Unit tests for URIs, signatures, refusals, blob CIDs, and the simplespace fallback against a stand-in PDS answering 501. fmt and clippy run here; the coverage gate and the answers check are left to the runner.\n\n## Shortcomings\n\n- Reads use `listRecords`, not `getRepo`'s archive, and check no MAC: zds answers `getRepo` with a CAR, not STAR, and these are live reads for a viewer rather than a sync, so there is no set hash kept to check against. grain's STAR-lite reader is not used here.\n- A collection read stops at 20 pages of 100.\n- The simplespace fallback is checked only against a stand-in, not pds.js or zds.\n- The first run builds the alpha (several minutes); later runs reuse `/opt/atproto`.\n\n## Review\n\nStart at `crates/grain/src/space.rs`; the harness changes are `harness/pds.mjs`, `harness/cov.mjs` and `.knotless/workflows/harness.yml`.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

grain::space, the core that private galleries and groups' pools are built on, after knotless's space.rs: a space's URI (at://<authority>/space/<type>/<skey>) and its parts; a credential to read one, made from a delegation token the reader's own PDS signs (getDelegationToken) and exchanged at the authority's PDS (getSpaceCredential) for a credential bound to a fresh P-256 key, each request signed for the repo it is addressed to (RFC 9421, as the alpha signs it); reading a repo's records (listRecords, every page), the space's writers (listRepos, credential only, as zds serves it) and a blob (getBlob) with it; the spaces an account's PDS lists (listSpaces, filtered by spaceType and pds.js's type); and Admin, what an account does with its own session: create a space with the memberspace policy, put a member to read or to read and write, list members, applyWrites, putRecord, deleteRecord and read its own repo there. denied and not_served tell an authority's no from a PDS with no such method.

grain::auth::verify_delegation checks a delegation token as knotless's does (its type, that it names the space's authority's PDS, the reader's signature), for an app to prove a reader with in a later pull.

The tests of spaces run on the spaces alpha. harness/pds.mjs runs the dev-env GRAIN_DEV_ENV names, and says spaces: true for one on the alpha; harness/cov.mjs runs the test binaries named spaces against one such harness and the rest against the npm PDS as before; harness.yml builds the alpha from atproto commit 11c5d98 (the one knotless's tests use) and caches it in /opt/atproto. AGENTS.md says how.

Why

The first of the stack porting private galleries and groups' pools off the old server. Every read or write of a space goes through what is here, so it comes first and alone.

The old server read the same way, but through its framework; it is copied from knotless's Rust, with grain's fallback to com.atproto.simplespace.* (pds.js, zds) kept: the reference names are asked first and the older ones when the PDS answers 404 or 501, in the shapes the old server's server/spaces/client.ts sent (did named, the policy a bare string in a nested config).

The alpha is built from a commit rather than installed from npm because npm's 0.0.0-spaces-alpha-* builds name their dependencies workspace:, so they do not install (bun says so; npm exits 1 silently).

How it was checked

crates/grain/tests/spaces.rs, against the alpha built locally from 11c5d98: a private gallery made and written with applyWrites, a reader put on it, its members listed, its blob read back by the reader with a credential, the owner finding it in listSpaces, an outsider refused at the exchange (denied), and a real delegation token verified; a pool made by a stand-in group, a member writing and deleting their own records there, the group reading them with a credential and listing its writers, an outsider's write kept by their own PDS but never listed as the space's, and the outsider refused. Unit tests for URIs, signatures, refusals, blob CIDs, and the simplespace fallback against a stand-in PDS answering 501. fmt and clippy run here; the coverage gate and the answers check are left to the runner.

Shortcomings

Reads use listRecords, not getRepo's archive, and check no MAC: zds answers getRepo with a CAR, not STAR, and these are live reads for a viewer rather than a sync, so there is no set hash kept to check against. grain's STAR-lite reader is not used here.
A collection read stops at 20 pages of 100.
The simplespace fallback is checked only against a stand-in, not pds.js or zds.
The first run builds the alpha (several minutes); later runs reuse /opt/atproto.

Review

Start at crates/grain/src/space.rs; the harness changes are harness/pds.mjs, harness/cov.mjs and .knotless/workflows/harness.yml.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"spaces/core"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mza452k5ol2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T05:44:32.007Z","body":"This pull adds `grain::space` (space URIs, credential exchange, signed reads, and `Admin` writes with a simplespace fallback) and `auth::verify_delegation`. It also adds a harness that runs the spaces tests against the alpha built from atproto commit `11c5d98`.\n\nI read `space.rs` in full, `verify_delegation` and `harness.yml`. I did not read the diffs of `harness/pds.mjs`, `harness/cov.mjs` or `tests/spaces.rs`. The four checks (`check`, `rust`, `test`, `harness`) were still queued when I looked, so nothing has run yet.\n\nI found nothing that must change.\n\n- **Delegation check:** it checks the token type, that the audience is the space authority's PDS, and the signature. `verify_jwt` also checks `exp`.\n- **Pagination:** the loops stop on an empty page or a repeated cursor and are capped.\n- **Signing:** the signing base matches the unit test.\n\nTwo notes to fix when convenient, neither blocking:\n- **Fallback loses the write flag:** in `put_member`, the `simplespace.addMember` fallback drops the `write` argument. A caller asking for read-only on pds.js or zds may get a different grant than on the alpha. Say so in the doc comment, or confirm what `addMember` grants.\n- **`denied` is broad:** it treats any 403 and `RepoNotFound` as the authority's no. A caller that retries or shows an error on this should know a missing member repo looks the same as a refusal.\n\nOnce the checks finish, make sure the coverage gate in `cov.json` holds, since the new `Admin` and fallback paths are only reached by the alpha tests.","html":"

This pull adds grain::space (space URIs, credential exchange, signed reads, and Admin writes with a simplespace fallback) and auth::verify_delegation. It also adds a harness that runs the spaces tests against the alpha built from atproto commit 11c5d98.

I read space.rs in full, verify_delegation and harness.yml. I did not read the diffs of harness/pds.mjs, harness/cov.mjs or tests/spaces.rs. The four checks (check, rust, test, harness) were still queued when I looked, so nothing has run yet.

I found nothing that must change.

Delegation check: it checks the token type, that the audience is the space authority's PDS, and the signature. verify_jwt also checks exp.
Pagination: the loops stop on an empty page or a repeated cursor and are capped.
Signing: the signing base matches the unit test.

Two notes to fix when convenient, neither blocking:

Fallback loses the write flag: in put_member, the simplespace.addMember fallback drops the write argument. A caller asking for read-only on pds.js or zds may get a different grant than on the alpha. Say so in the doc comment, or confirm what addMember grants.
denied is broad: it treats any 403 and RepoNotFound as the authority's no. A caller that retries or shows an error on this should know a missing member repo looks the same as a refusal.

Once the checks finish, make sure the coverage gate in cov.json holds, since the new Admin and fallback paths are only reached by the alpha tests.

\n","verdict":"approve","commit":"63dc79f99be420332e122a5fb76dd35049f01ebb"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzafjav64m2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T08:32:24.989Z","body":"Landed on feature/rust at fc5f686 through the batch pull at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzadedttgi2b, checked there as a whole. This pull's head is in feature/rust's history.","html":"

Landed on feature/rust at fc5f686 through the batch pull Seven reviewed pulls land on feature/rust together, checked once, checked there as a whole. This pull's head is in feature/rust's history.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mza452k5ol2b","commit":"63dc79f99be420332e122a5fb76dd35049f01ebb","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"63dc79f99be420332e122a5fb76dd35049f01ebb"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mza3zzrrcfku/card.png?v=f04fbfbd95cbf3d8"}

grain.social/grain Switch repository Loading…

Spaces are read and written from grain's core, tested on the alpha

grain.social/grain

Switch repository

Loading…