{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza75hfdbrq6","kind":"pull","title":"Accounts mute and unmute, and list whom they block and mute","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T06:38:26.706Z","updatedAt":"2026-11-01T07:36:44.221Z","comments":3},"body":"## What changes\n\n**Muting.** `social.grain.graph.muteActor` and `unmuteActor` keep a mute in the index's `mute` table (`crates/grain-serve/src/graph.rs`, `index/graph.rs`). The apps call them with a service token, the web with its cookie from a page of the site, as every procedure is held (`viewer::writer`). Muting one already muted, or unmuting one not muted, changes nothing; an account cannot mute itself, and `actor` is a DID, as the lexicon says. What a muted account says the reads already leave out (`read::moderation::unmuted`).\n\n**Lists.** `social.grain.graph.getMutes` and `getBlocks` list the viewer's own, the latest first, paged by the cursor every list here takes (`::`), `limit` 1 to 100. Each item is who the account is (`did`, `handle`, `displayName`, `avatar`), and a block's its `blockUri`. Every one is listed, taken down or not, so that each can be taken back.\n\nThis is the first of the pulls that close what the clients call and grain-serve did not serve. Each is its own, on `feature/rust`, to land alone: `gaps/graph` (this), `gaps/stories` (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza7bthk3h5m), `gaps/sitemap` (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza7hjmguydu), `gaps/deletes` (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzaa6mrnggip), `gaps/cross-post` (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza7q2lwfpy5), `gaps/web` (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza7ndhqehfr).\n\n## What the clients call, and what grain-serve serves\n\nW is the web as `web/reads` and `web/writes-client` leave it; I and A are the iOS and Android apps, which still call the old names (mapped through `lexicons/README.md`). \"Served\" is feature/rust before these pulls.\n\n| Method (old name the apps call) | Callers | Served | Pull |\n| --- | --- | --- | --- |\n| `social.grain.actor.getProfile` (`unspecced.getActorProfile`) | W I A | yes | |\n| `social.grain.actor.getPreferences` (`dev.hatk.getPreferences`) | W I A | yes | |\n| `social.grain.actor.putPreferences` (`dev.hatk.putPreference`) | W I A | yes | |\n| `social.grain.actor.getFavorites` (`getActorFavorites`) | W I A | yes | |\n| `social.grain.actor.getSuggestedFollows` | W I | yes | |\n| `social.grain.actor.searchActors` (`searchProfiles`) | W I A | yes | |\n| `social.grain.actor.searchActorsTypeahead` | W A | yes | |\n| `social.grain.feed.describeFeeds` | W | yes | |\n| `social.grain.feed.getFeed` (`dev.hatk.getFeed`) | W I A | yes | |\n| `social.grain.gallery.getGallery`, `getFavorites`, `getCameras`, `getLocations`, `searchGalleries` | W I A | yes | |\n| `social.grain.comment.getThread` (`getCommentThread`) | W I A | yes | |\n| `social.grain.graph.getFollowers`, `getFollowing`, `getKnownFollowers` | W I A | yes | |\n| `social.grain.graph.getBlocks` | W I A | **no** | this one, `gaps/graph` |\n| `social.grain.graph.getMutes` | W I A | **no** | this one, `gaps/graph` |\n| `social.grain.graph.muteActor`, `unmuteActor` | W I A | **no** | this one, `gaps/graph` |\n| `social.grain.notification.listNotifications`, `getUnreadCount` (`getNotifications`) | W I A | yes | |\n| `social.grain.notification.updateSeen` (`putPreference` of `lastSeenNotifications`) | W I A | yes | |\n| `social.grain.notification.registerPush`, `unregisterPush` (`dev.hatk.push.*`) | I A | yes | |\n| `social.grain.story.getAuthors`, `getStories`, `getStory` | W I A | yes | |\n| `social.grain.story.getArchive` (`getStoryArchive`) | W I A | **no** | `gaps/stories` |\n| `social.grain.story.markViewed` (`markStoriesViewed`) | W I A | **no** | `gaps/stories` |\n| `social.grain.server.getSitemap` | W (server side) | **no** | `gaps/sitemap` |\n| `social.grain.gallery.deleteGallery` | W I A | **no** | `gaps/deletes` |\n| `social.grain.server.deleteAccount` | W I A | **no** | `gaps/deletes` |\n| `social.grain.repo.createRecord`, `putRecord`, `deleteRecord`, `applyWrites`, `uploadBlob` | W | yes | |\n| the same, of `app.bsky.feed.post` (the Bluesky cross-post) | W, I (by `dev.hatk.createRecord`/`putRecord`) | yes: said to be refused, but it is taken | `gaps/cross-post`, a test only |\n| `dev.hatk.createRecord`, `putRecord`, `deleteRecord`, `applyWrites`, `uploadBlob` | I A | no, by design | the apps write `com.atproto.repo.*` to their own PDS, then `social.grain.sync.indexRecords` (served) |\n| `dev.hatk.getRecord` | I A | no, by design | `com.atproto.repo.getRecord` at the account's PDS |\n| `com.atproto.moderation.createReport` (`dev.hatk.createReport`) | W I A | yes | |\n| `dev.hatk.describeLabels` | I A | **in part** | `com.atproto.label.queryLabels` is served; the label definitions are only `social.grain.admin.listLabelDefinitions`, admins only. Open: see below |\n| `com.atproto.repo.getRecord`, `com.atproto.sync.getBlob` | W | not grain-serve's | the account's PDS |\n| `com.atproto.identity.resolveHandle` | W I | not grain-serve's | public.api.bsky.app |\n| private galleries (`privateGallery.*`, `getSpaceSupport`, `/space-blob`) | W | no | the spaces port (`spaces/galleries`) |\n| groups and pools (`group.*`, `group.pool.*`) | W | no | the spaces port (`spaces/groups`, `spaces/pools`) |\n| `/oauth/session`, `/oauth/login`, `/oauth/switch`, `/oauth/logout`, `/oauth-client-metadata.json` | W | yes | |\n| `/og/profile/...` | W | yes | |\n| every other path: the web's pages | browsers | no: Caddy sends them to the app | `gaps/web` (`GRAIN_WEB`) |\n| `/oauth/par`, `/oauth/authorize`, `/oauth/token` (the old server as the apps' authorization server) | I A | no | open: see below |\n\nOpen, not built here:\n\n- **The apps' logins.** iOS and Android log in to grain.social as their OAuth authorization server. grain-serve is no authorization server; `lexicons/README.md`'s plan is for the apps to log in at their own PDS and call grain-serve with service tokens. That is the apps' move, and nothing in grain-serve stands in for it.\n- **Label definitions for the apps.** `dev.hatk.describeLabels` gave anyone grain's label definitions. Bluesky's way is the labeler's `app.bsky.labeler.service` record, read by `app.bsky.labeler.getServices`; grain publishes none yet. The web ships them in `$lib/labels`, and the apps can too until grain does.\n\n\n## Why\n\nThe web (`web/writes-client`) and both apps call these, and grain-serve answered 501.\n\nknotless has no mutes. Its `dev.knotless.listBlocks` (`knotless-serve/src/web/account_settings.rs`) reads blocks from the account's own repo at its PDS, so a block lists as soon as it is made; grain's are in the index already, which a web write reaches before it answers and an app's reaches through `indexRecords`, so `getBlocks` reads the index and keeps grain's lexicon, whose shape the web was moved onto.\n\n## Differences from the old server\n\n- A cursor names the last row's time and URI (or DID), not an offset, so a page does not skip or repeat as mutes and blocks are made between pages.\n- An account with no handle the index knows is `handle.invalid`, as every view here names one, where the old server gave its DID as its handle.\n- A mute's `actor` that is not a DID is refused (400), and muting oneself is `InvalidRequest`, where the old server threw a 500.\n- `limit` out of 1 to 100 is refused, not clamped.\n\n## How it was checked\n\n`crates/grain-serve/tests/graph.rs`, against the reference PDS for the service tokens: muting three accounts and one again, the list paged and its items, unmuting twice, a self-mute, a handle and no actor refused, no token and the wrong method's token refused; blocks listed newest first with their records, another's block left out, one taken down kept, paged, and bad limits and cursors refused. `index/graph.rs` has a unit test of the table, and the plan check (`the_reads_read_by_index`) covers both lists' queries. The rest is the runner's.\n\n## Shortcomings\n\n- The web's muting goes through `viewer::writer`, so it needs a page of the site, as the other procedures do; not tried in a browser.\n- Mutes stay in the index when an account is deleted until `gaps/deletes` lands, whose purge takes them.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

Muting. social.grain.graph.muteActor and unmuteActor keep a mute in the index's mute table (crates/grain-serve/src/graph.rs, index/graph.rs). The apps call them with a service token, the web with its cookie from a page of the site, as every procedure is held (viewer::writer). Muting one already muted, or unmuting one not muted, changes nothing; an account cannot mute itself, and actor is a DID, as the lexicon says. What a muted account says the reads already leave out (read::moderation::unmuted).

Lists. social.grain.graph.getMutes and getBlocks list the viewer's own, the latest first, paged by the cursor every list here takes (<createdAt>::<uri or did>), limit 1 to 100. Each item is who the account is (did, handle, displayName, avatar), and a block's its blockUri. Every one is listed, taken down or not, so that each can be taken back.

This is the first of the pulls that close what the clients call and grain-serve did not serve. Each is its own, on feature/rust, to land alone: gaps/graph (this), gaps/stories (Stories are archived, and what each account watched follows it), gaps/sitemap (The sitemap names the profiles and galleries a search engine may show), gaps/deletes (Galleries and accounts are deleted, and a deleted account only once its host agrees), gaps/cross-post (The web's Bluesky cross-post goes through grain-serve, and a test says so), gaps/web (grain-serve hands the web's pages to its app, at --web).

What the clients call, and what grain-serve serves

W is the web as web/reads and web/writes-client leave it; I and A are the iOS and Android apps, which still call the old names (mapped through lexicons/README.md). \"Served\" is feature/rust before these pulls.

\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n

Method (old name the apps call)	Callers	Served	Pull
`social.grain.actor.getProfile` (`unspecced.getActorProfile`)	W I A	yes
`social.grain.actor.getPreferences` (`dev.hatk.getPreferences`)	W I A	yes
`social.grain.actor.putPreferences` (`dev.hatk.putPreference`)	W I A	yes
`social.grain.actor.getFavorites` (`getActorFavorites`)	W I A	yes
`social.grain.actor.getSuggestedFollows`	W I	yes
`social.grain.actor.searchActors` (`searchProfiles`)	W I A	yes
`social.grain.actor.searchActorsTypeahead`	W A	yes
`social.grain.feed.describeFeeds`	W	yes
`social.grain.feed.getFeed` (`dev.hatk.getFeed`)	W I A	yes
`social.grain.gallery.getGallery`, `getFavorites`, `getCameras`, `getLocations`, `searchGalleries`	W I A	yes
`social.grain.comment.getThread` (`getCommentThread`)	W I A	yes
`social.grain.graph.getFollowers`, `getFollowing`, `getKnownFollowers`	W I A	yes
`social.grain.graph.getBlocks`	W I A	no	this one, `gaps/graph`
`social.grain.graph.getMutes`	W I A	no	this one, `gaps/graph`
`social.grain.graph.muteActor`, `unmuteActor`	W I A	no	this one, `gaps/graph`
`social.grain.notification.listNotifications`, `getUnreadCount` (`getNotifications`)	W I A	yes
`social.grain.notification.updateSeen` (`putPreference` of `lastSeenNotifications`)	W I A	yes
`social.grain.notification.registerPush`, `unregisterPush` (`dev.hatk.push.*`)	I A	yes
`social.grain.story.getAuthors`, `getStories`, `getStory`	W I A	yes
`social.grain.story.getArchive` (`getStoryArchive`)	W I A	no	`gaps/stories`
`social.grain.story.markViewed` (`markStoriesViewed`)	W I A	no	`gaps/stories`
`social.grain.server.getSitemap`	W (server side)	no	`gaps/sitemap`
`social.grain.gallery.deleteGallery`	W I A	no	`gaps/deletes`
`social.grain.server.deleteAccount`	W I A	no	`gaps/deletes`
`social.grain.repo.createRecord`, `putRecord`, `deleteRecord`, `applyWrites`, `uploadBlob`	W	yes
the same, of `app.bsky.feed.post` (the Bluesky cross-post)	W, I (by `dev.hatk.createRecord`/`putRecord`)	yes: said to be refused, but it is taken	`gaps/cross-post`, a test only
`dev.hatk.createRecord`, `putRecord`, `deleteRecord`, `applyWrites`, `uploadBlob`	I A	no, by design	the apps write `com.atproto.repo.*` to their own PDS, then `social.grain.sync.indexRecords` (served)
`dev.hatk.getRecord`	I A	no, by design	`com.atproto.repo.getRecord` at the account's PDS
`com.atproto.moderation.createReport` (`dev.hatk.createReport`)	W I A	yes
`dev.hatk.describeLabels`	I A	in part	`com.atproto.label.queryLabels` is served; the label definitions are only `social.grain.admin.listLabelDefinitions`, admins only. Open: see below
`com.atproto.repo.getRecord`, `com.atproto.sync.getBlob`	W	not grain-serve's	the account's PDS
`com.atproto.identity.resolveHandle`	W I	not grain-serve's	public.api.bsky.app
private galleries (`privateGallery.*`, `getSpaceSupport`, `/space-blob`)	W	no	the spaces port (`spaces/galleries`)
groups and pools (`group.`, `group.pool.`)	W	no	the spaces port (`spaces/groups`, `spaces/pools`)
`/oauth/session`, `/oauth/login`, `/oauth/switch`, `/oauth/logout`, `/oauth-client-metadata.json`	W	yes
`/og/profile/...`	W	yes
every other path: the web's pages	browsers	no: Caddy sends them to the app	`gaps/web` (`GRAIN_WEB`)
`/oauth/par`, `/oauth/authorize`, `/oauth/token` (the old server as the apps' authorization server)	I A	no	open: see below

Open, not built here:

The apps' logins. iOS and Android log in to grain.social as their OAuth authorization server. grain-serve is no authorization server; lexicons/README.md's plan is for the apps to log in at their own PDS and call grain-serve with service tokens. That is the apps' move, and nothing in grain-serve stands in for it.
Label definitions for the apps. dev.hatk.describeLabels gave anyone grain's label definitions. Bluesky's way is the labeler's app.bsky.labeler.service record, read by app.bsky.labeler.getServices; grain publishes none yet. The web ships them in $lib/labels, and the apps can too until grain does.

Why

The web (web/writes-client) and both apps call these, and grain-serve answered 501.

knotless has no mutes. Its dev.knotless.listBlocks (knotless-serve/src/web/account_settings.rs) reads blocks from the account's own repo at its PDS, so a block lists as soon as it is made; grain's are in the index already, which a web write reaches before it answers and an app's reaches through indexRecords, so getBlocks reads the index and keeps grain's lexicon, whose shape the web was moved onto.

Differences from the old server

A cursor names the last row's time and URI (or DID), not an offset, so a page does not skip or repeat as mutes and blocks are made between pages.
An account with no handle the index knows is handle.invalid, as every view here names one, where the old server gave its DID as its handle.
A mute's actor that is not a DID is refused (400), and muting oneself is InvalidRequest, where the old server threw a 500.
limit out of 1 to 100 is refused, not clamped.

How it was checked

crates/grain-serve/tests/graph.rs, against the reference PDS for the service tokens: muting three accounts and one again, the list paged and its items, unmuting twice, a self-mute, a handle and no actor refused, no token and the wrong method's token refused; blocks listed newest first with their records, another's block left out, one taken down kept, paged, and bad limits and cursors refused. index/graph.rs has a unit test of the table, and the plan check (the_reads_read_by_index) covers both lists' queries. The rest is the runner's.

Shortcomings

The web's muting goes through viewer::writer, so it needs a page of the site, as the other procedures do; not tried in a browser.
Mutes stay in the index when an account is deleted until gaps/deletes lands, whose purge takes them.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"gaps/graph"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mza76gip532b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T06:38:59.323Z","body":"This adds `muteActor` and `unmuteActor`, which write the existing `mute` table through `viewer::writer`, and `getMutes` and `getBlocks`, which are keyset-paged reads of the viewer's own rows. I found nothing that must change.\n\n- **Schema:** the `mute` table exists with primary key `(did, subject)`. `INSERT OR IGNORE` and `DELETE` therefore give the idempotent behaviour the body describes.\n- **Cursors:** the cursor and `limit` handling reuses `Params::after`, `Params::limit` and `page`. The row-value comparisons match the `ORDER BY`, so pages should neither skip nor repeat rows.\n- **Validation:** the actor is checked as a DID, self-mute is refused, and the routes follow the pattern of the other procedures.\n- **Tests:** they cover paging, taken-down accounts staying listed, bad input and auth failures.\n\nI did not run the checks or read their results. Please confirm the `harness` and `rust` checks are green before merging, since the coverage gate and the answer-schema check are strict.","html":"

This adds muteActor and unmuteActor, which write the existing mute table through viewer::writer, and getMutes and getBlocks, which are keyset-paged reads of the viewer's own rows. I found nothing that must change.

Schema: the mute table exists with primary key (did, subject). INSERT OR IGNORE and DELETE therefore give the idempotent behaviour the body describes.
Cursors: the cursor and limit handling reuses Params::after, Params::limit and page. The row-value comparisons match the ORDER BY, so pages should neither skip nor repeat rows.
Validation: the actor is checked as a DID, self-mute is refused, and the routes follow the pattern of the other procedures.
Tests: they cover paging, taken-down accounts staying listed, bad input and auth failures.

I did not run the checks or read their results. Please confirm the harness and rust checks are green before merging, since the coverage gate and the answer-schema check are strict.

\n","verdict":"approve","commit":"af38c5ea523d0898e6875eaa3ab57104d5ca3cf4"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzaadsiwiv2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T06:59:53.427Z","body":"Carried forward: the change this pull makes at `3c2008a56e19d9c70dfb0dd50c39d5a591de49ad` is the one reviewed at `af38c5ea523d0898e6875eaa3ab57104d5ca3cf4`, so that review stands. What is new comes from its base.","html":"

Carried forward: the change this pull makes at 3c2008a56e19d9c70dfb0dd50c39d5a591de49ad is the one reviewed at af38c5ea523d0898e6875eaa3ab57104d5ca3cf4, so that review stands. What is new comes from its base.

\n","verdict":"approve","commit":"3c2008a56e19d9c70dfb0dd50c39d5a591de49ad"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzafjqvdsx2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T08:32:41.772Z","body":"Landed on feature/rust at fc5f686 through the batch pull at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzadedttgi2b, checked there as a whole. This pull's head is in feature/rust's history.","html":"

Landed on feature/rust at fc5f686 through the batch pull Seven reviewed pulls land on feature/rust together, checked once, checked there as a whole. This pull's head is in feature/rust's history.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzaadsiwiv2b","commit":"3c2008a56e19d9c70dfb0dd50c39d5a591de49ad","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"3c2008a56e19d9c70dfb0dd50c39d5a591de49ad"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mza75hfdbrq6/card.png?v=de03fb306689f3fd"}

grain.social/grain Switch repository Loading…

Accounts mute and unmute, and list whom they block and mute

grain.social/grain

Switch repository

Loading…