{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza7b7mlb7rw","kind":"pull","title":"Deploys and lexicon publishes wait on the Rust checks too","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T06:40:32.773Z","comments":3},"body":"## What changes\n\n**Deploys wait on every check.** `deploy.yml` and `publish-lexicons.yml` waited on `test check`, the Node app's, alone, so a Rust failure on main would not have stopped a deploy or a lexicon publish. Both now wait on `check test rust harness`. Deploy waits over two steps, `checks done` (waits, never fails) then `checks pass` (judges), each under the runner's 30 minutes a step, as knotless's `deploy.yml` does, since four checks behind a busy runner can outlast one step's 25 minutes.\n\n**Pre-flight.** `check.yml`, `test.yml`, `rust.yml` and `harness.yml` take `queue: first`, with knotless's comments: the merge queue takes a pull into a batch only once these have passed at its head.\n\n**Cutover notes.** `rust.yml` and `harness.yml` say they become `check.yml` and `test.yml`, as knotless names them, over the Node ones, and that deploy's and publish's lists then go back to `check test` (plus `lexicons`). The Node `check.yml` and `test.yml` say they are replaced then, and that what `check.yml` checks of `web/` moves to a `web.yml` as knotless's does.\n\nMirrors knotless's `.knotless/workflows/check.yml`, `test.yml` (`queue: first` and its comments) and `deploy.yml` (the list of every check, and the `checks done` / `checks pass` pair).\n\n## Why\n\nUntil cutover the Node app still deploys from main, so its checks stay; but the Rust half lands on main with this branch, and a check that does not gate deploy is one nobody has to fix. Renaming now would break the Node app's gate, so the rename is left to cutover, written down where it will be done.\n\n## How it was checked\n\nYAML read over by hand; this pull's own checks run the four pre-flight workflows with `queue: first`. deploy.yml and publish-lexicons.yml run only on main, so their new steps first run when this branch lands there.\n\n## Shortcomings\n\n- Not copied: knotless's `harness/changes.sh`. It asks a pull changing knotless's published client crates for a knope change file; grain publishes no client package and has no `.changeset/`, so there is nothing for it to check.\n- Not ported from knotless's `harness/cov.mjs`: `COV_STORE` (the cache of passing test runs, `/opt/testcache`), `COV_NETS` (stock-only on pulls, the spaces alpha on the batch) and the alpha net. Each is a couple of hundred lines entangled with the spaces alpha build; worth doing once grain's tests run against the alpha too, not as a gate change.\n- `lexicons` is not in the lists: the lexicon lint is its own pull, which says to add it here once both land.\n- Publish-lexicons waits over one step, as knotless's does.\n\n## Review\n\nA quick look: the two `for wf in` lists and the new deploy step.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

Deploys wait on every check. deploy.yml and publish-lexicons.yml waited on test check, the Node app's, alone, so a Rust failure on main would not have stopped a deploy or a lexicon publish. Both now wait on check test rust harness. Deploy waits over two steps, checks done (waits, never fails) then checks pass (judges), each under the runner's 30 minutes a step, as knotless's deploy.yml does, since four checks behind a busy runner can outlast one step's 25 minutes.

Pre-flight. check.yml, test.yml, rust.yml and harness.yml take queue: first, with knotless's comments: the merge queue takes a pull into a batch only once these have passed at its head.

Cutover notes. rust.yml and harness.yml say they become check.yml and test.yml, as knotless names them, over the Node ones, and that deploy's and publish's lists then go back to check test (plus lexicons). The Node check.yml and test.yml say they are replaced then, and that what check.yml checks of web/ moves to a web.yml as knotless's does.

Mirrors knotless's .knotless/workflows/check.yml, test.yml (queue: first and its comments) and deploy.yml (the list of every check, and the checks done / checks pass pair).

Why

Until cutover the Node app still deploys from main, so its checks stay; but the Rust half lands on main with this branch, and a check that does not gate deploy is one nobody has to fix. Renaming now would break the Node app's gate, so the rename is left to cutover, written down where it will be done.

How it was checked

YAML read over by hand; this pull's own checks run the four pre-flight workflows with queue: first. deploy.yml and publish-lexicons.yml run only on main, so their new steps first run when this branch lands there.

Shortcomings

Not copied: knotless's harness/changes.sh. It asks a pull changing knotless's published client crates for a knope change file; grain publishes no client package and has no .changeset/, so there is nothing for it to check.
Not ported from knotless's harness/cov.mjs: COV_STORE (the cache of passing test runs, /opt/testcache), COV_NETS (stock-only on pulls, the spaces alpha on the batch) and the alpha net. Each is a couple of hundred lines entangled with the spaces alpha build; worth doing once grain's tests run against the alpha too, not as a gate change.
lexicons is not in the lists: the lexicon lint is its own pull, which says to add it here once both land.
Publish-lexicons waits over one step, as knotless's does.

Review

A quick look: the two for wf in lists and the new deploy step.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"infra/ci-gates"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mza7c2raug2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T06:41:01.238Z","body":"This pull makes `deploy.yml` and `publish-lexicons.yml` wait on `check test rust harness`. It splits deploy's wait into `checks done`, which never fails, and `checks pass`, which judges. It also adds `queue: first` to the four pre-flight workflows and writes the cutover notes into the comments.\n\nI read the two `for wf in` lists and the new deploy step, and they are consistent. `rust` and `harness` both run on pushes to main, so deploy and publish will find those checks to wait on. In `checks done`, `|| true` and `break` on an exhausted budget keep the step from failing, and `checks pass` still fails closed. It also removes the candidate image when a check hasn't passed. Both steps are under the 30-minute step limit.\n\nThis pull's four checks were still queued when I looked, so I can't say they passed. As the description says, the new deploy and publish steps run only on main, so their first real run is after this lands.","html":"

This pull makes deploy.yml and publish-lexicons.yml wait on check test rust harness. It splits deploy's wait into checks done, which never fails, and checks pass, which judges. It also adds queue: first to the four pre-flight workflows and writes the cutover notes into the comments.

I read the two for wf in lists and the new deploy step, and they are consistent. rust and harness both run on pushes to main, so deploy and publish will find those checks to wait on. In checks done, || true and break on an exhausted budget keep the step from failing, and checks pass still fails closed. It also removes the candidate image when a check hasn't passed. Both steps are under the 30-minute step limit.

This pull's four checks were still queued when I looked, so I can't say they passed. As the description says, the new deploy and publish steps run only on main, so their first real run is after this lands.

\n","verdict":"approve","commit":"0581bfaafc88c45bf7775e1653a61960e8341d9c"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzadh7ybms2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T07:55:29.450Z","body":"Since my last review, the pull only gained a merge of `batch/one` (head `8ec5991`). The merge's one conflict was in `harness.yml`. I read the resolved file: the `queue: first` line and its comment, and the cutover note, are intact, and the `on` and `cache` blocks and steps are coherent. Nothing from my earlier review needed changing, and the deploy and publish changes I looked at then are untouched by the merge. The four pre-flight checks (`check`, `test`, `rust`, `harness`) are still queued at this commit, so I can't say they pass. The new deploy and publish steps run only on main, as the description says.","html":"

Since my last review, the pull only gained a merge of batch/one (head 8ec5991). The merge's one conflict was in harness.yml. I read the resolved file: the queue: first line and its comment, and the cutover note, are intact, and the on and cache blocks and steps are coherent. Nothing from my earlier review needed changing, and the deploy and publish changes I looked at then are untouched by the merge. The four pre-flight checks (check, test, rust, harness) are still queued at this commit, so I can't say they pass. The new deploy and publish steps run only on main, as the description says.

\n","verdict":"approve","commit":"8ec5991fd122c0dc121e6aab5b7e86b3d60bd981"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzajspnohb2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T09:49:17.430Z","body":"Landed on feature/rust at 164794a, fast-forwarded with infra/justfile (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzaa2rxkrwa2), which contains this head and passed every check against fc5f686.","html":"

Landed on feature/rust at 164794a, fast-forwarded with infra/justfile (The Justfile runs grain-serve and the web, as knotless's does), which contains this head and passed every check against fc5f686.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzadh7ybms2b","commit":"8ec5991fd122c0dc121e6aab5b7e86b3d60bd981","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"8ec5991fd122c0dc121e6aab5b7e86b3d60bd981"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mza7b7mlb7rw/card.png?v=b21303908a39ac4e"}

grain.social/grain Switch repository Loading…

Deploys and lexicon publishes wait on the Rust checks too

grain.social/grain

Switch repository

Loading…