{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mza7q2lwfpy5","kind":"pull","title":"The web's Bluesky cross-post goes through grain-serve, and a test says so","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T06:48:50.825Z","updatedAt":"2026-11-01T07:36:24.335Z","comments":5},"body":"## What changes\n\nNothing in grain-serve: a test, `crates/grain-serve/tests/cross_post.rs`, that the Bluesky cross-post works through it as the web makes one. A browser logged in through the site writes a gallery, uploads a picture with `social.grain.repo.uploadBlob`, and writes an `app.bsky.feed.post` with `social.grain.repo.createRecord`: text with tag and link facets, `tags`, and an `app.bsky.embed.images` embed of the blob. The post is at the account's PDS, and `getGallery` names it straight after, `crossPost.url` being `https://bsky.app/profile//post/`. `putRecord` at the same key edits it, as the web's edit flow does, and a post of 3001 characters is refused `InvalidRecord`.\n\n## Why\n\nThe web pull said grain-serve refused the cross-post. It does not: `social.grain.repo.*` writes any collection the index takes, checked against its lexicon, and the index takes `app.bsky.feed.post` (the `bsky_post` table, which is how a gallery knows its cross-post). The test holds that in place.\n\nWhat the old server allowed, for the record: its `dev.hatk.createRecord`, `putRecord` and `applyWrites` took any collection it had a lexicon for, limited by the session's OAuth scope, and the only Bluesky collection in grain's scope is `app.bsky.feed.post`, for create and update. grain-serve takes `app.bsky.feed.post` and no other Bluesky collection, writes it at the account's own PDS with its session, checks the request comes from a page of the site (`login::same_site`) and that `repo` is the session's own, as for grain's collections.\n\n## How it was checked\n\nThe test, on the runner at this head with the others (`check`, `rust`, `test`, `harness` passed). knotless writes nothing of Bluesky's, so there is nothing of its to follow here.\n\n## Shortcomings\n\n- `deleteRecord` of the post is not in the test; it goes through the same path as any other collection's.\n- The apps cross-post by `dev.hatk.createRecord`, which grain-serve does not serve by design: they write the post at their own PDS and call `social.grain.sync.indexRecords`.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

Nothing in grain-serve: a test, crates/grain-serve/tests/cross_post.rs, that the Bluesky cross-post works through it as the web makes one. A browser logged in through the site writes a gallery, uploads a picture with social.grain.repo.uploadBlob, and writes an app.bsky.feed.post with social.grain.repo.createRecord: text with tag and link facets, tags, and an app.bsky.embed.images embed of the blob. The post is at the account's PDS, and getGallery names it straight after, crossPost.url being https://bsky.app/profile/<did>/post/<rkey>. putRecord at the same key edits it, as the web's edit flow does, and a post of 3001 characters is refused InvalidRecord.

Why

The web pull said grain-serve refused the cross-post. It does not: social.grain.repo.* writes any collection the index takes, checked against its lexicon, and the index takes app.bsky.feed.post (the bsky_post table, which is how a gallery knows its cross-post). The test holds that in place.

What the old server allowed, for the record: its dev.hatk.createRecord, putRecord and applyWrites took any collection it had a lexicon for, limited by the session's OAuth scope, and the only Bluesky collection in grain's scope is app.bsky.feed.post, for create and update. grain-serve takes app.bsky.feed.post and no other Bluesky collection, writes it at the account's own PDS with its session, checks the request comes from a page of the site (login::same_site) and that repo is the session's own, as for grain's collections.

How it was checked

The test, on the runner at this head with the others (check, rust, test, harness passed). knotless writes nothing of Bluesky's, so there is nothing of its to follow here.

Shortcomings

deleteRecord of the post is not in the test; it goes through the same path as any other collection's.
The apps cross-post by dev.hatk.createRecord, which grain-serve does not serve by design: they write the post at their own PDS and call social.grain.sync.indexRecords.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"gaps/cross-post"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzachfd2fw2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T07:37:41.304Z","body":"This adds `crates/grain-serve/tests/cross_post.rs`. It covers the web's Bluesky cross-post through `social.grain.repo.*`: gallery create, `uploadBlob`, an `app.bsky.feed.post` with facets, tags and an images embed, a PDS readback, `getGallery`'s `crossPost.url`, a `putRecord` edit, and a 3001-character post refused with `InvalidRecord`. It changes no server code. The `check`, `rust`, `test` and `harness` workflows all passed at this head, which covers fmt, clippy, the coverage gate and the answers check. I found nothing that must change. The `deleteRecord` gap is stated in the body and is minor.","html":"

This adds crates/grain-serve/tests/cross_post.rs. It covers the web's Bluesky cross-post through social.grain.repo.*: gallery create, uploadBlob, an app.bsky.feed.post with facets, tags and an images embed, a PDS readback, getGallery's crossPost.url, a putRecord edit, and a 3001-character post refused with InvalidRecord. It changes no server code. The check, rust, test and harness workflows all passed at this head, which covers fmt, clippy, the coverage gate and the answers check. I found nothing that must change. The deleteRecord gap is stated in the body and is minor.

\n","verdict":"approve","commit":"eea1c93b56741d723818a141a86b0b35b656ead2"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzag6bfkzd2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T08:44:10.170Z","body":"Carried forward: the change this pull makes at `42065d02bf4c21aed1810b84ab7ab6f3b7daa463` is the one reviewed at `eea1c93b56741d723818a141a86b0b35b656ead2`, so that review stands. What is new comes from its base.","html":"

Carried forward: the change this pull makes at 42065d02bf4c21aed1810b84ab7ab6f3b7daa463 is the one reviewed at eea1c93b56741d723818a141a86b0b35b656ead2, so that review stands. What is new comes from its base.

\n","verdict":"approve","commit":"42065d02bf4c21aed1810b84ab7ab6f3b7daa463"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzakgpkblv2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T10:00:28.407Z","body":"Carried forward: the change this pull makes at `521183a02db91002f3f22393ac5a72b2ee076bee` is the one reviewed at `42065d02bf4c21aed1810b84ab7ab6f3b7daa463`, so that review stands. What is new comes from its base.","html":"

Carried forward: the change this pull makes at 521183a02db91002f3f22393ac5a72b2ee076bee is the one reviewed at 42065d02bf4c21aed1810b84ab7ab6f3b7daa463, so that review stands. What is new comes from its base.

\n","verdict":"approve","commit":"521183a02db91002f3f22393ac5a72b2ee076bee"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzamusnvom2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T10:44:08.917Z","body":"Carried forward: the change this pull makes at `a196eff0bed177c7d852c50dbb6eb43994f76466` is the one reviewed at `521183a02db91002f3f22393ac5a72b2ee076bee`, so that review stands. What is new comes from its base.","html":"

Carried forward: the change this pull makes at a196eff0bed177c7d852c50dbb6eb43994f76466 is the one reviewed at 521183a02db91002f3f22393ac5a72b2ee076bee, so that review stands. What is new comes from its base.

\n","verdict":"approve","commit":"a196eff0bed177c7d852c50dbb6eb43994f76466"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzattpcprl2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T12:48:48.043Z","body":"Landed on feature/rust at 7d031dc through the batch pull at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzaosmbzpj2b, checked there as a whole. This pull's head is in feature/rust's history.","html":"

Landed on feature/rust at 7d031dc through the batch pull The web proxy, deletes and the cross-post test land together, checked once, checked there as a whole. This pull's head is in feature/rust's history.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzamusnvom2b","commit":"a196eff0bed177c7d852c50dbb6eb43994f76466","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"a196eff0bed177c7d852c50dbb6eb43994f76466"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mza7q2lwfpy5/card.png?v=5e938ae57c93420a"}

grain.social/grain Switch repository Loading…

The web's Bluesky cross-post goes through grain-serve, and a test says so

grain.social/grain

Switch repository

Loading…