{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzap4bfp25zk","kind":"pull","title":"An account Jetstream says was deleted goes only when an answer says so","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T11:24:06.741Z","comments":2},"body":"## What changes\n\n**Three answers, not two.** When Jetstream says an account was deleted, `accounts::ask` now asks where its identity points and answers one of three things (`crates/grain-serve/src/accounts.rs`):\n\n- `Here`: the host's `com.atproto.sync.getRepoStatus` says `active: true`. The account moved there, so it stays.\n- `Gone`: the host says `active: false`, or refuses with `RepoNotFound`, or PLC (or the `did:web` host) answers `410` (a tombstone) or `404` (nothing there). Only these purge.\n- `Unsure`: anything else. The DID document can't be read (transport error, a 5xx), it names no PDS, the PDS can't be reached or answers with an error other than `RepoNotFound`, or it answers with no `active`.\n\n**Asked again, then kept.** `accounts::settle` asks until an answer settles it, doubling the wait each time. `Patience::default()` is six asks, starting at 30 s and capped at 10 min a wait, about half an hour in all. If it is still `Unsure` after that, it logs an error and keeps everything. `deletions` gives each account its own task (a `JoinSet`), so one account waiting holds none of the others up, and it ends once the stream's channel closes and every task has settled. `jetstream::follow` passes the default patience.\n\n## Why\n\nA passing PLC or network failure met while handling a Jetstream deletion of an account that had moved used to count as gone. That purged state nothing rebuilds: preferences, push tokens, mutes, story views and invites. Purging is the one answer that can't be undone, so it now waits for a host or directory to actually say so.\n\n**knotless does not do this.** Its `knotless-serve/src/accounts.rs` `deleted()` takes an identity that fails to resolve, or a status call that errors, as deleted (`active != Some(true)`), which is the shape grain had. So this is grain's own, and the right change is to make it in knotless too. What knotless loses to a false purge is less (it keeps less per account), which is likely why it hasn't mattered there.\n\n## How it was checked\n\n`crates/grain-serve/tests/gone.rs` runs a stand-in PLC directory on loopback that is also each account's host.\n- `ask` answers `Here` for an active repo.\n- It answers `Gone` for `active: false`, `RepoNotFound`, a `410` tombstone and a `404`.\n- It answers `Unsure` for PLC answering 503, the host answering 502, a host nobody listens on, a status with no `active`, and a document that names no PDS.\n- `settle` keeps an active account, purges one whose PLC fails once and then says it is inactive, and gives up on one PLC never answers. Its preferences and host status are left as they were.\n- `deletions` purges a tombstone and keeps an account it couldn't ask, both sent through the channel at once.\n\n`tests/deletes.rs`'s guard test now checks `ask` against the reference PDS: an account there is `Here`, and a DID its PLC never heard of is `Gone`. Those tests ran here; the rest is the runner's.\n\n## Shortcomings\n\n- `active: false` counts as gone, as asked for, even when its `status` says `deactivated` at the new host. Deactivated accounts already sit out of reads until they're back, so this is the stricter of the two readings.\n- An account whose PLC stays down for the whole half hour is never purged by this event. A later `deleted` event, or an admin, has to do it.\n- The waits live in memory. A restart part way through drops the accounts still waiting, and they're kept.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)\n","html":"

What changes

Three answers, not two. When Jetstream says an account was deleted, accounts::ask now asks where its identity points and answers one of three things (crates/grain-serve/src/accounts.rs):

Here: the host's com.atproto.sync.getRepoStatus says active: true. The account moved there, so it stays.
Gone: the host says active: false, or refuses with RepoNotFound, or PLC (or the did:web host) answers 410 (a tombstone) or 404 (nothing there). Only these purge.
Unsure: anything else. The DID document can't be read (transport error, a 5xx), it names no PDS, the PDS can't be reached or answers with an error other than RepoNotFound, or it answers with no active.

Asked again, then kept. accounts::settle asks until an answer settles it, doubling the wait each time. Patience::default() is six asks, starting at 30 s and capped at 10 min a wait, about half an hour in all. If it is still Unsure after that, it logs an error and keeps everything. deletions gives each account its own task (a JoinSet), so one account waiting holds none of the others up, and it ends once the stream's channel closes and every task has settled. jetstream::follow passes the default patience.

Why

A passing PLC or network failure met while handling a Jetstream deletion of an account that had moved used to count as gone. That purged state nothing rebuilds: preferences, push tokens, mutes, story views and invites. Purging is the one answer that can't be undone, so it now waits for a host or directory to actually say so.

knotless does not do this. Its knotless-serve/src/accounts.rs deleted() takes an identity that fails to resolve, or a status call that errors, as deleted (active != Some(true)), which is the shape grain had. So this is grain's own, and the right change is to make it in knotless too. What knotless loses to a false purge is less (it keeps less per account), which is likely why it hasn't mattered there.

How it was checked

crates/grain-serve/tests/gone.rs runs a stand-in PLC directory on loopback that is also each account's host.

ask answers Here for an active repo.
It answers Gone for active: false, RepoNotFound, a 410 tombstone and a 404.
It answers Unsure for PLC answering 503, the host answering 502, a host nobody listens on, a status with no active, and a document that names no PDS.
settle keeps an active account, purges one whose PLC fails once and then says it is inactive, and gives up on one PLC never answers. Its preferences and host status are left as they were.
deletions purges a tombstone and keeps an account it couldn't ask, both sent through the channel at once.

tests/deletes.rs's guard test now checks ask against the reference PDS: an account there is Here, and a DID its PLC never heard of is Gone. Those tests ran here; the rest is the runner's.

Shortcomings

active: false counts as gone, as asked for, even when its status says deactivated at the new host. Deactivated accounts already sit out of reads until they're back, so this is the stricter of the two readings.
An account whose PLC stays down for the whole half hour is never purged by this event. A later deleted event, or an admin, has to do it.
The waits live in memory. A restart part way through drops the accounts still waiting, and they're kept.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"gaps/gone"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzap65og7x2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T11:25:09.942Z","body":"This makes a Jetstream \"account deleted\" event purge only when an answer says the account is gone. `ask` returns `Here`, `Gone` or `Unsure`. `settle` re-asks with doubling waits and keeps the account if it is still `Unsure` after six asks. `deletions` runs one task per account. I read the new logic in `accounts.rs` and the `identity::document` it relies on, and it matches the description. The tests are reported as run on the runner. I did not read them or the checks, and did not read the diff for `tests/gone.rs` or `tests/deletes.rs`.\n\nI found nothing that has to change. Two points to be aware of, both minor:\n- **`did:web` 404:** a `did:web` host that answers `404` counts as `Gone` and purges at once. A host that misconfigures its `/.well-known/did.json` for a moment would purge an account. That is what the description says it wants, and PLC `404` and `410` are unambiguous. If you want to be stricter, make a `did:web` `404` `Unsure`.\n- **Repeat events:** two deletion events for one DID spawn two independent `settle` tasks. They are idempotent, so this is harmless, but each waits out the full schedule.","html":"

This makes a Jetstream \"account deleted\" event purge only when an answer says the account is gone. ask returns Here, Gone or Unsure. settle re-asks with doubling waits and keeps the account if it is still Unsure after six asks. deletions runs one task per account. I read the new logic in accounts.rs and the identity::document it relies on, and it matches the description. The tests are reported as run on the runner. I did not read them or the checks, and did not read the diff for tests/gone.rs or tests/deletes.rs.

I found nothing that has to change. Two points to be aware of, both minor:

did:web 404: a did:web host that answers 404 counts as Gone and purges at once. A host that misconfigures its /.well-known/did.json for a moment would purge an account. That is what the description says it wants, and PLC 404 and 410 are unambiguous. If you want to be stricter, make a did:web 404 Unsure.
Repeat events: two deletion events for one DID spawn two independent settle tasks. They are idempotent, so this is harmless, but each waits out the full schedule.

\n","verdict":"approve","commit":"d071e0b23160b82f23ba8506b5edb941e7bf5f61"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzaqmhsgxg62","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T11:51:04.063Z","body":"Closed: the coordinator moved this fix onto batch/two (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzaosmbzpj2b), at 48472f4, as its reviewer asked.","html":"

Closed: the coordinator moved this fix onto batch/two (The web proxy, deletes and the cross-post test land together, checked once), at 48472f4, as its reviewer asked.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzap65og7x2b","commit":"d071e0b23160b82f23ba8506b5edb941e7bf5f61","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"d071e0b23160b82f23ba8506b5edb941e7bf5f61"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mzap4bfp25zk/card.png?v=c69c3ad49606d1e2"}

grain.social/grain Switch repository Loading…

An account Jetstream says was deleted goes only when an answer says so

grain.social/grain

Switch repository

Loading…