{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzb6w4hcgu2b","kind":"pull","title":"deploy: grain-serve hands the pages every request it does not answer","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T16:07:00.094Z","comments":2},"body":"## What changes\n\n**serve runs with `--web http://pages:2601`.** Every request grain-serve does not answer itself goes to the SvelteKit app over the project's own network, so the proxy sends grain's domain to `grain-serve:2600` and nothing else. The pages leave the proxy network: nothing outside the project reaches them.\n\n**deploy/README.md's Caddy snippet** is one `reverse_proxy grain-serve:2600`, without the path split.\n\n## Why\n\n`--web` landed in batch/two, but the compose file still left it off and had Caddy split paths between serve and pages. This mirrors knotless's `deploy/docker-compose.yml`, where knotless-serve runs with `--web http://pages:2591` and its pages are on the default network alone.\n\nIt's needed now for next.grain.social: grain-serve beside the old server on grain's host, ahead of cutover. Its Caddy block in hetzner-infra is a single `reverse_proxy grain-serve:2600`.\n\n## How it was checked\n\nLeft to CI. The first real run is the next.grain.social deploy.\n\n## Shortcomings\n\nNone known. HOST_HEADER and PROTOCOL_HEADER stay on pages, because grain-serve sets `x-forwarded-host` and `x-forwarded-proto` when it hands a request on (`pages.rs`).\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

serve runs with --web http://pages:2601. Every request grain-serve does not answer itself goes to the SvelteKit app over the project's own network, so the proxy sends grain's domain to grain-serve:2600 and nothing else. The pages leave the proxy network: nothing outside the project reaches them.

deploy/README.md's Caddy snippet is one reverse_proxy grain-serve:2600, without the path split.

Why

--web landed in batch/two, but the compose file still left it off and had Caddy split paths between serve and pages. This mirrors knotless's deploy/docker-compose.yml, where knotless-serve runs with --web http://pages:2591 and its pages are on the default network alone.

It's needed now for next.grain.social: grain-serve beside the old server on grain's host, ahead of cutover. Its Caddy block in hetzner-infra is a single reverse_proxy grain-serve:2600.

How it was checked

Left to CI. The first real run is the next.grain.social deploy.

Shortcomings

None known. HOST_HEADER and PROTOCOL_HEADER stay on pages, because grain-serve sets x-forwarded-host and x-forwarded-proto when it hands a request on (pages.rs).

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"deploy/web"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzb6xof6vh2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T16:07:52.454Z","body":"This runs grain-serve with `--web http://pages:2601`. It drops the pages' `proxy` network and `grain-pages` alias, and it cuts the Caddy snippet to a single `reverse_proxy grain-serve:2600`. I checked the claims against `feature/rust`:\n- `pages.rs` does set `x-forwarded-host` from Host and defaults `x-forwarded-proto` to `http`, keeping any value the proxy already set. HOST_HEADER and PROTOCOL_HEADER on pages therefore still work.\n- No `grain-pages` reference remains outside the lines this pull edits, so nothing else depends on the removed alias.\n- The `pages` name resolves on the project's default network, where both services already sit.\n\nI found nothing that needs changing. The pull relies on CI and the next.grain.social deploy as its test, so check that first deploy for the host and scheme the pages see.","html":"

This runs grain-serve with --web http://pages:2601. It drops the pages' proxy network and grain-pages alias, and it cuts the Caddy snippet to a single reverse_proxy grain-serve:2600. I checked the claims against feature/rust:

pages.rs does set x-forwarded-host from Host and defaults x-forwarded-proto to http, keeping any value the proxy already set. HOST_HEADER and PROTOCOL_HEADER on pages therefore still work.
No grain-pages reference remains outside the lines this pull edits, so nothing else depends on the removed alias.
The pages name resolves on the project's default network, where both services already sit.

I found nothing that needs changing. The pull relies on CI and the next.grain.social deploy as its test, so check that first deploy for the host and scheme the pages see.

\n","verdict":"approve","commit":"b90142998f843b8bd666e5aa3f9311bbdec1431a"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzbeolzcod2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T17:50:10.429Z","body":"Landed on feature/rust in batch/three (…/3mzbdo7hmjf2b, 236806f), with its head b901429 unchanged.","html":"

Landed on feature/rust in batch/three (…/3mzbdo7hmjf2b, 236806f), with its head b901429 unchanged.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzb6xof6vh2b","commit":"b90142998f843b8bd666e5aa3f9311bbdec1431a","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"b90142998f843b8bd666e5aa3f9311bbdec1431a"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mzb6w4hcgu2b/card.png?v=c4d76159154bf983"}

grain.social/grain Switch repository Loading…

deploy: grain-serve hands the pages every request it does not answer

grain.social/grain

Switch repository

Loading…