{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzbf2zhtwr4z","kind":"pull","title":"A gallery titled past its lexicon is indexed whole and shown cut","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T17:57:07.189Z","updatedAt":"2026-11-01T19:14:59.497Z","comments":3},"body":"## What changes\n\n**Indexing.** A `social.grain.gallery` whose own strings (`title`, `description`) run past their lexicon `maxLength` is indexed, by Jetstream, backfill and `grain-import` alike, instead of refused. It goes through one function, `Lexicons::validate_indexed` in `crates/grain/src/lexicon.rs`: for a gallery it checks a copy with those top-level strings cut to their bound, so every other rule (formats, required fields, nested strings such as `address.country`, other collections) still refuses as before. The index keeps the whole record, so `record` in a view round-trips.\n\n**Writes.** `Index::check`, which web and space writes go through before they reach the PDS, stays strict: grain never writes a title past 100.\n\n**Views.** `galleryView.title` is the first 100 graphemes of the title and `galleryView.description` the first 1000 of the description, with nothing appended (`lexicon::cut`, `views::gallery_title`). The notification list's gallery title and the OG card's are cut the same way; the card's own ellipsis on width is unchanged.\n\n## Why\n\nSix galleries on the network have titles over 100 (e.g. at://did:plc:7dgiqud6mtxy7kat43rh4c2c/social.grain.gallery/3mymoygaeefbg). The import refused them with `title: string too long (max 100)` where the old server had them. The owner decided to index them and cut the title where it is shown. Description went with it because it is the same check on the same record; nothing else is loosened.\n\nMirrored from knotless: `theme.rs`'s colours, which take a value one way \"as a reader takes them\" and another \"as a writer must give them\", with a `strict` flag. Here `Index::parsed` takes `strict` the same way: `check` (writers) passes true, `put` (the network) false. knotless has no lexicon validator with an exception like this, so the exception itself is new.\n\n## How it was checked\n\n`check`, `harness`, `rust`, `test` and `lexicons` pass at `0362694`. Tests added:\n- `grain::lexicon`: `an_index_keeps_a_gallery_that_runs_long` (long title and description pass; a bad `createdAt`, a non-string title, a long nested `address.country` and a long profile `displayName` still refuse) and `a_view_cuts_by_graphemes` (combining marks count as one).\n- `grain-serve` index: `a_gallery_titled_past_its_lexicon_is_indexed_whole_but_not_written` (check refuses, put takes it whole); `records_that_do_not_fit_are_refused` now uses a bad datetime where it used a long title.\n- `grain-serve` read: `a_gallery_titled_past_its_lexicon_is_shown_cut` (getGallery cuts by graphemes, `record` whole).\n- `grain-import`: `a_gallery_titled_past_its_lexicon_is_imported_whole` (imported whole; one with a bad `createdAt` still refused).\n\n## Shortcomings\n\nThe six galleries come in at the next import or backfill of their repos; nothing re-fetches them by itself. A gallery's search entry holds the whole title, so search matches words past the cut. Space galleries read from member repos (`spaces/pool.rs`, `spaces/gallery.rs`) are not cut.\n\n## Review\n\nStart at `validate_indexed` in `crates/grain/src/lexicon.rs`, then `parsed` in `crates/grain-serve/src/index/mod.rs`.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

Indexing. A social.grain.gallery whose own strings (title, description) run past their lexicon maxLength is indexed, by Jetstream, backfill and grain-import alike, instead of refused. It goes through one function, Lexicons::validate_indexed in crates/grain/src/lexicon.rs: for a gallery it checks a copy with those top-level strings cut to their bound, so every other rule (formats, required fields, nested strings such as address.country, other collections) still refuses as before. The index keeps the whole record, so record in a view round-trips.

Writes. Index::check, which web and space writes go through before they reach the PDS, stays strict: grain never writes a title past 100.

Views. galleryView.title is the first 100 graphemes of the title and galleryView.description the first 1000 of the description, with nothing appended (lexicon::cut, views::gallery_title). The notification list's gallery title and the OG card's are cut the same way; the card's own ellipsis on width is unchanged.

Why

Six galleries on the network have titles over 100 (e.g. at://did:plc:7dgiqud6mtxy7kat43rh4c2c/social.grain.gallery/3mymoygaeefbg). The import refused them with title: string too long (max 100) where the old server had them. The owner decided to index them and cut the title where it is shown. Description went with it because it is the same check on the same record; nothing else is loosened.

Mirrored from knotless: theme.rs's colours, which take a value one way \"as a reader takes them\" and another \"as a writer must give them\", with a strict flag. Here Index::parsed takes strict the same way: check (writers) passes true, put (the network) false. knotless has no lexicon validator with an exception like this, so the exception itself is new.

How it was checked

check, harness, rust, test and lexicons pass at 0362694. Tests added:

grain::lexicon: an_index_keeps_a_gallery_that_runs_long (long title and description pass; a bad createdAt, a non-string title, a long nested address.country and a long profile displayName still refuse) and a_view_cuts_by_graphemes (combining marks count as one).
grain-serve index: a_gallery_titled_past_its_lexicon_is_indexed_whole_but_not_written (check refuses, put takes it whole); records_that_do_not_fit_are_refused now uses a bad datetime where it used a long title.
grain-serve read: a_gallery_titled_past_its_lexicon_is_shown_cut (getGallery cuts by graphemes, record whole).
grain-import: a_gallery_titled_past_its_lexicon_is_imported_whole (imported whole; one with a bad createdAt still refused).

Shortcomings

The six galleries come in at the next import or backfill of their repos; nothing re-fetches them by itself. A gallery's search entry holds the whole title, so search matches words past the cut. Space galleries read from member repos (spaces/pool.rs, spaces/gallery.rs) are not cut.

Review

Start at validate_indexed in crates/grain/src/lexicon.rs, then parsed in crates/grain-serve/src/index/mod.rs.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"gaps/long-titles"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzbf7hxlj72b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T17:59:36.603Z","body":"This pull lets the index keep galleries whose `title` or `description` is past its lexicon bound. `Lexicons::validate_indexed` checks a copy with those top-level strings cut to `maxLength`, so every other rule still refuses. `Index::parsed` takes `strict`: `check` (writes) passes true, `put` passes false. Views, notifications and the OG card cut the title to 100 graphemes, and `getGallery` cuts the description to 1000.\n\nI found nothing that must change.\n- **Edge cases.** The byte cut backs up to a char boundary, so it can't split a character. A non-object record falls through to the normal validator, which refuses it. Non-string, bad-format and nested-string failures still refuse, and the tests cover them.\n- **Scope.** Only `social.grain.gallery` is loosened.\n- **Cut sizes.** The lexicon's `maxLength` counts bytes and the view cuts by graphemes, so a view can show up to 100 graphemes even when that is over 100 bytes. That fits the stated intent.\n- **Checks.** I didn't read the CI results.\n- **Known gaps.** The pull body already lists the search and space-gallery gaps.","html":"

This pull lets the index keep galleries whose title or description is past its lexicon bound. Lexicons::validate_indexed checks a copy with those top-level strings cut to maxLength, so every other rule still refuses. Index::parsed takes strict: check (writes) passes true, put passes false. Views, notifications and the OG card cut the title to 100 graphemes, and getGallery cuts the description to 1000.

I found nothing that must change.

Edge cases. The byte cut backs up to a char boundary, so it can't split a character. A non-object record falls through to the normal validator, which refuses it. Non-string, bad-format and nested-string failures still refuse, and the tests cover them.
Scope. Only social.grain.gallery is loosened.
Cut sizes. The lexicon's maxLength counts bytes and the view cuts by graphemes, so a view can show up to 100 graphemes even when that is over 100 bytes. That fits the stated intent.
Checks. I didn't read the CI results.
Known gaps. The pull body already lists the search and space-gallery gaps.

\n","verdict":"approve","commit":"de6dd09ed0430b8cb591f67aa0c6b2e26e70f6ec"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzbhtpr5he2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T18:46:43.353Z","body":"The only change since my last review is in a test, `an_index_keeps_a_gallery_that_runs_long`. The strict-refusal assertion now uses a gallery with a long title and no long description. Before, it used the gallery that also had a 1001-byte description. The test therefore shows that the title alone is refused by the strict validator, and that message is now the title's. This makes the assertion more precise and doesn't change any behaviour. My earlier approval stands, and I found nothing that must change.","html":"

The only change since my last review is in a test, an_index_keeps_a_gallery_that_runs_long. The strict-refusal assertion now uses a gallery with a long title and no long description. Before, it used the gallery that also had a 1001-byte description. The test therefore shows that the title alone is refused by the strict validator, and that message is now the title's. This makes the assertion more precise and doesn't change any behaviour. My earlier approval stands, and I found nothing that must change.

\n","verdict":"approve","commit":"036269406a3bfdbc425cd1196ad7a25c4c0da310"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzbk2psuaw2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T19:26:25.773Z","body":"Landed on feature/rust in batch/four (…/3mzbjho3qgd2b, 785dbe4), with its head 0362694 unchanged.","html":"

Landed on feature/rust in batch/four (…/3mzbjho3qgd2b, 785dbe4), with its head 0362694 unchanged.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzbhtpr5he2b","commit":"036269406a3bfdbc425cd1196ad7a25c4c0da310","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"036269406a3bfdbc425cd1196ad7a25c4c0da310"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mzbf2zhtwr4z/card.png?v=76b5ba4dd4da3d59"}

grain.social/grain Switch repository Loading…

A gallery titled past its lexicon is indexed whole and shown cut

grain.social/grain

Switch repository

Loading…