{"item":{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzbfcztrfzsb","kind":"pull","title":"A web login seeds a grain profile from the account's Bluesky profile","state":"closed","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T18:01:36.003Z","updatedAt":"2026-11-01T19:15:01.213Z","comments":3},"body":"## What changes\n\n**A web login seeds a grain profile.** Once the callback has kept the session, `login::profile::seed` runs in the background (`tokio::spawn`), so the redirect never waits on it and a failure is only logged (`seeding a profile from Bluesky`). If the account's `social.grain.actor.profile/self` is missing or has no `displayName`, it reads `app.bsky.actor.profile/self` and writes a grain profile with its `displayName`, `description` and `avatar` (the blob ref as is), and a `createdAt` kept from the grain profile there was, or now. An existing one is put over (`putRecord`, swapped on the CID read); otherwise one is created at rkey `self`.\n\n**The write goes through the web session** with `write::put` and a new `write::create`, factored out of `createRecord` as `put` already was of `putRecord`. So it is checked against the lexicon, refreshed and retried as other web writes are, and indexed before it returns. `sync::get_record` is shared for the two reads.\n\n## Why\n\nThe old server's on-login hook did this, so a new grain account shows the name and picture it has on Bluesky. Ported as it was, with two differences:\n\n- Both profiles are read from the account's PDS, not the grain one from the index. The index may not have the account yet at its first login, and reading it there would create over a profile that exists (refused) or miss one to keep `createdAt` from.\n- The put swaps on the CID it read, so an edit made meanwhile is not overwritten.\n\nMirrored from knotless: knotless-serve's login callback sets off `spaces::discover(&app, &did)` once the session is kept, a `tokio::spawn` that never holds up the redirect and whose failure is only logged. `profile::seed` has the same shape and sits at the same point in `callback`. knotless itself makes no profile at login (its pages fall back on the Bluesky profile when reading), so the seeding is ported from the old server.\n\n**The apps' sign-in** (at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.pull/3mzb6nkbx3q2b) has no hook for this. The apps sign in at their own PDS and call grain-serve with service tokens through `atproto-proxy`. grain-serve never sees the login, and it holds no session to write to their repo with: `viewer::viewer` only verifies a token per call. So no first call could do the write. The apps do need the same, since they used to sign in through the old server and got its hook. It has to be done in each app after sign-in: read both profiles from its PDS, write the grain profile there, then call `social.grain.sync.indexRecords`. Not built here.\n\n## How it was checked\n\n`check`, `harness`, `rust`, `test` and `lexicons` pass at `fc53a26`. Added:\n- `a_login_seeds_a_grain_profile_from_bluesky` (tests/login.rs, reference PDS). An account with a Bluesky profile and avatar and no grain profile gets one, in the index and at its PDS. One with an unnamed grain profile the index never saw is put over and keeps its `createdAt`. One with a named grain profile is left alone. One with no Bluesky profile gets nothing. Every login still answers 303.\n- An account with no web session: `seeded` fails with `AuthenticationRequired`, and the background task ends quietly.\n- `a_bluesky_profile_gives_what_it_has` (unit): empty strings and banner/pronouns are left out, and createdAt is kept.\n\n## Shortcomings\n\n- An account with an unnamed grain profile and a Bluesky profile with no name is put over on every login, as the old server did.\n- A Bluesky avatar the grain lexicon would not take, such as a webp, fails the grain write's check. That is logged and nothing is written.\n- Group accounts made through `login::provisioned` are not seeded, as they have no Bluesky profile.\n\n## Review\n\nStart at `crates/grain-serve/src/login/profile.rs`, then the one line in `login::callback`.\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)","html":"

What changes

A web login seeds a grain profile. Once the callback has kept the session, login::profile::seed runs in the background (tokio::spawn), so the redirect never waits on it and a failure is only logged (seeding a profile from Bluesky). If the account's social.grain.actor.profile/self is missing or has no displayName, it reads app.bsky.actor.profile/self and writes a grain profile with its displayName, description and avatar (the blob ref as is), and a createdAt kept from the grain profile there was, or now. An existing one is put over (putRecord, swapped on the CID read); otherwise one is created at rkey self.

The write goes through the web session with write::put and a new write::create, factored out of createRecord as put already was of putRecord. So it is checked against the lexicon, refreshed and retried as other web writes are, and indexed before it returns. sync::get_record is shared for the two reads.

Why

The old server's on-login hook did this, so a new grain account shows the name and picture it has on Bluesky. Ported as it was, with two differences:

Both profiles are read from the account's PDS, not the grain one from the index. The index may not have the account yet at its first login, and reading it there would create over a profile that exists (refused) or miss one to keep createdAt from.
The put swaps on the CID it read, so an edit made meanwhile is not overwritten.

Mirrored from knotless: knotless-serve's login callback sets off spaces::discover(&app, &did) once the session is kept, a tokio::spawn that never holds up the redirect and whose failure is only logged. profile::seed has the same shape and sits at the same point in callback. knotless itself makes no profile at login (its pages fall back on the Bluesky profile when reading), so the seeding is ported from the old server.

The apps' sign-in (server: The apps sign in at their own PDS, as grain-serve's public client) has no hook for this. The apps sign in at their own PDS and call grain-serve with service tokens through atproto-proxy. grain-serve never sees the login, and it holds no session to write to their repo with: viewer::viewer only verifies a token per call. So no first call could do the write. The apps do need the same, since they used to sign in through the old server and got its hook. It has to be done in each app after sign-in: read both profiles from its PDS, write the grain profile there, then call social.grain.sync.indexRecords. Not built here.

How it was checked

check, harness, rust, test and lexicons pass at fc53a26. Added:

a_login_seeds_a_grain_profile_from_bluesky (tests/login.rs, reference PDS). An account with a Bluesky profile and avatar and no grain profile gets one, in the index and at its PDS. One with an unnamed grain profile the index never saw is put over and keeps its createdAt. One with a named grain profile is left alone. One with no Bluesky profile gets nothing. Every login still answers 303.
An account with no web session: seeded fails with AuthenticationRequired, and the background task ends quietly.
a_bluesky_profile_gives_what_it_has (unit): empty strings and banner/pronouns are left out, and createdAt is kept.

Shortcomings

An account with an unnamed grain profile and a Bluesky profile with no name is put over on every login, as the old server did.
A Bluesky avatar the grain lexicon would not take, such as a webp, fails the grain write's check. That is logged and nothing is written.
Group accounts made through login::provisioned are not seeded, as they have no Bluesky profile.

Review

Start at crates/grain-serve/src/login/profile.rs, then the one line in login::callback.

🤖 Generated with Claude Code

\n","base":"feature/rust","head":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"branch":"gaps/seed-profile"},"comments":[{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzbfev2npz2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T18:02:38.109Z","body":"This pull seeds a grain profile from the account's Bluesky profile in a background task after a web login. It does the write through the web session with a new `write::create`, factored out of `createRecord` the way `put` was out of `putRecord`.\n\nI found nothing that must change.\n\n- **Refactor:** `create_record` now delegates to `create` with the same body, so the XRPC behaviour is unchanged.\n- **Seeding logic:** it reads both profiles from the PDS, skips an account whose grain profile already has a name, and keeps `createdAt` when there was a profile. It puts over an existing profile with `swapRecord` set to the CID it read and creates at `self` otherwise.\n- **Failure handling:** failures are only logged, so the redirect never waits on them.\n- **Tests:** the integration test covers the made, put-over-unnamed, named and no-Bluesky cases. The unit test covers field filtering and `createdAt`.\n\nI couldn't confirm the tests pass: the `rust`, `harness`, `test` and `check` runs were still queued when I looked. Please make sure they come back green before it merges, especially the coverage gate on the harness.\n\nIf an account logs in twice at nearly the same moment, both background tasks could read \"no grain profile\" and race to create it. The loser's create fails and is only logged, so this is harmless.","html":"

This pull seeds a grain profile from the account's Bluesky profile in a background task after a web login. It does the write through the web session with a new write::create, factored out of createRecord the way put was out of putRecord.

I found nothing that must change.

Refactor: create_record now delegates to create with the same body, so the XRPC behaviour is unchanged.
Seeding logic: it reads both profiles from the PDS, skips an account whose grain profile already has a name, and keeps createdAt when there was a profile. It puts over an existing profile with swapRecord set to the CID it read and creates at self otherwise.
Failure handling: failures are only logged, so the redirect never waits on them.
Tests: the integration test covers the made, put-over-unnamed, named and no-Bluesky cases. The unit test covers field filtering and createdAt.

I couldn't confirm the tests pass: the rust, harness, test and check runs were still queued when I looked. Please make sure they come back green before it merges, especially the coverage gate on the harness.

If an account logs in twice at nearly the same moment, both background tasks could read \"no grain profile\" and race to create it. The loser's create fails and is only logged, so this is harmless.

\n","verdict":"approve","commit":"bc600f6478313049f76e6a69bee504848023be96"},{"uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzbht5vivg2b","author":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"createdAt":"2026-11-01T18:46:24.621Z","body":"Since my earlier approval, the pull has one new commit. `seed` now returns its `JoinHandle`, and `callback` drops it, so the redirect still doesn't wait. The test now also covers a DID with no web session. `seeded` returns an `AuthenticationRequired` error for it, and the awaited `seed` handle finishes cleanly because the failure is only logged. I have nothing to add.\n\nThe `rust`, `harness`, `test` and `check` runs were still queued when I looked. Make sure they pass before this merges, especially the coverage gate on the harness.","html":"

Since my earlier approval, the pull has one new commit. seed now returns its JoinHandle, and callback drops it, so the redirect still doesn't wait. The test now also covers a DID with no web session. seeded returns an AuthenticationRequired error for it, and the awaited seed handle finishes cleanly because the failure is only logged. I have nothing to add.

The rust, harness, test and check runs were still queued when I looked. Make sure they pass before this merges, especially the coverage gate on the harness.

\n","verdict":"approve","commit":"fc53a26b696b476fbe00a533926e7c77773e4eaa"},{"uri":"at://did:plc:bcgltzqazw5tb6k2g3ttenbj/dev.knotless.comment/3mzbk2rw6sd2b","author":{"did":"did:plc:bcgltzqazw5tb6k2g3ttenbj","handle":"chadtmiller.com","avatar":"https://cdn.bsky.app/img/avatar/plain/did:plc:bcgltzqazw5tb6k2g3ttenbj/bafkreig5bcb7dl7aphw6eg4e7kjkvpdshfexdvk7jldg53ypre6ecdhesu@jpeg"},"createdAt":"2026-11-01T19:26:27.980Z","body":"Landed on feature/rust in batch/four (…/3mzbjho3qgd2b, 785dbe4), with its head fc53a26 unchanged.","html":"

Landed on feature/rust in batch/four (…/3mzbjho3qgd2b, 785dbe4), with its head fc53a26 unchanged.

\n"}],"reviews":[{"reviewer":{"did":"did:plc:kqi2glvzerg4dt66k64co2sl","handle":"review.knotless.dev","bot":true},"verdict":"approve","uri":"at://did:plc:kqi2glvzerg4dt66k64co2sl/dev.knotless.comment/3mzbht5vivg2b","commit":"fc53a26b696b476fbe00a533926e7c77773e4eaa","outdated":false,"maintainer":false}],"closes":[],"checks":[],"minutes":[{"runner":{"did":"did:plc:4bocpkn5zkwe4wuu4plrj5kt","handle":"runner.knotless.dev","bot":true},"minutes":2505,"freeing":[{"at":"2026-11-25T00:00:00Z","minutes":2},{"at":"2026-11-27T00:00:00Z","minutes":24},{"at":"2026-11-28T00:00:00Z","minutes":10},{"at":"2026-11-29T00:00:00Z","minutes":7},{"at":"2026-11-30T00:00:00Z","minutes":310},{"at":"2026-12-01T00:00:00Z","minutes":1355},{"at":"2026-12-02T00:00:00Z","minutes":509},{"at":"2026-12-06T00:00:00Z","minutes":43},{"at":"2026-12-07T00:00:00Z","minutes":185},{"at":"2026-12-08T00:00:00Z","minutes":16},{"at":"2026-12-09T00:00:00Z","minutes":38}],"updatedAt":"2026-11-10T01:31:15.298Z"},{"runner":{"did":"did:plc:ejh2v3z5ieqhqgz3ybk6r35x","handle":"ci.knotless.dev","bot":true},"minutes":28,"freeing":[{"at":"2026-11-29T00:00:00Z","minutes":2},{"at":"2026-11-30T00:00:00Z","minutes":7},{"at":"2026-12-01T00:00:00Z","minutes":1},{"at":"2026-12-06T00:00:00Z","minutes":6},{"at":"2026-12-07T00:00:00Z","minutes":8}],"updatedAt":"2026-11-08T00:05:20.251Z"}],"changes":{"repo":{"did":"did:plc:e7rftrdyz5e2rw4y6ocszew2","handle":"grain.social","name":"grain"},"commits":[],"files":[],"head":"fc53a26b696b476fbe00a533926e7c77773e4eaa"},"card":"/grain.social/grain/pull/did:plc:bcgltzqazw5tb6k2g3ttenbj/3mzbfcztrfzsb/card.png?v=a57eda20a78d3693"}

grain.social/grain Switch repository Loading…

A web login seeds a grain profile from the account's Bluesky profile

grain.social/grain

Switch repository

Loading…