0
2
ci: Merge main into feature/rust, onto knotless's shared steps
Mergedchadtmiller.com added 1 commit
Approved
This merges main's shared-steps change into feature/rust. I found nothing that has to change.
check.ymlandtest.ymlswap the pastedpackagesstep fornpm-ci@1. Thequeue: firstpre-flight, thefeature/*pull trigger and the cutover notes stay.publish-lexicons.ymlmatches main's file. The one difference is the wait list, which ischeck test rust harness lexicons, the five workflowsfeature/rustwaited on. I read that as intended.uses.lockmatches what the workflows reference:npm-ci@1,publish-lexicons@1andwait-for-checks@2.- No references to the deleted
deploy/publish-lexicons.mjsremain on the branch. I searched for the name and found none.
When I looked, the check, test, rust and harness runs were still queued or running, and only lexicons had finished, skipped as expected. I'd wait for them to pass before merging, since they are the only exercise of npm-ci here.
Merged as 7482d4b
Part of a stack of 2
- ci: Merge main into feature/rust, onto knotless's shared steps
- main
What changes
This merges main at 0eb252c ("ci: the workflows use knotless's shared steps") into
feature/rust. It conflicted in three workflow files; each keeps both sides.check.yml,test.yml: main'schadtmiller.com/steps/npm-ci@1replaces the pastedpackagesstep.feature/rust'squeue: firstpre-flight, itspulltrigger onrefs/heads/feature/*, and its cutover notes stay.publish-lexicons.yml: main'spublish-lexicons@1(plan, and publish at main) andwait-for-checks@2replace the script and the hand-written checks loop. The wait names all five workflows thatfeature/rust's loop waited on:check test rust harness lexicons, not main'stest check. The step's default wait, 25 minutes, is the same as the old loop's.deploy/publish-lexicons.mjsgoes, as on main..knotless/uses.lockcomes in from main unchanged.Why
The standing pull from
feature/rustinto main (grain runs on a Rust server modelled on knotless, without hatk) stopped checking: every workflow failed with "conflicts with main at 0eb252c". Its job is to say whether the whole branch still passes against main. AGENTS.md says to merge main into the feature branch as main moves.How it was checked
Left to CI: this pull's
checkandtestrun thenpm-cistep.publish-lexiconsruns only at main or when asked, so its steps aren't exercised here; they're the same steps main already runs.🤖 Generated with Claude Code