1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
//! Artifact resolver tests: digest cache, mismatch rejection, computed
//! digests, byte caps, retries, mirror round-trip, and blob uploads.
mod common;
#[path = "../src/release/artifacts.rs"]
mod artifacts;
// `artifacts.rs` is not yet declared by `src/release/mod.rs`; these shims let
// the same file compile inside this test crate with its `crate::` imports.
mod db {
pub use vuln_notif::db::*;
}
mod pds {
pub use vuln_notif::pds::*;
}
mod records {
pub use vuln_notif::records::*;
}
mod release {
pub mod artifact {
pub use vuln_notif::release::artifact::*;
}
pub mod http {
pub use vuln_notif::release::http::*;
}
}
use std::collections::HashMap;
use std::io::Read;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::{Arc, Mutex};
use async_trait::async_trait;
use serde_json::{Value, json};
use wiremock::matchers::{method, path};
use wiremock::{Mock, MockServer, ResponseTemplate};
use vuln_notif::db::DbHandle;
use vuln_notif::release::artifact::{Purl, parse_purl};
use vuln_notif::release::http::{DownloadTooLarge, RegistryHttp, ReqwestRegistryHttp};
const REPO: &str = "did:plc:test";
const MAX_BYTES: u64 = 10 * 1024 * 1024;
const PYPI_JSON_URL: &str = "https://pypi.org/pypi/acme-widget/json";
const WHEEL_URL: &str =
"https://files.pythonhosted.org/packages/ee/ff/acme_widget-1.2.3-py3-none-any.whl";
const SDIST_URL: &str = "https://files.pythonhosted.org/packages/cc/dd/acme_widget-1.2.3.tar.gz";
const WHEEL_SHA: &str = "1052c88adb8be0a046765e7a91d3a561d3f12b4c43c19ca0aec800167749b343";
const SDIST_SHA: &str = "3020aaf1136f4cee21cd01100d9bf88c0ad5a783dfd29c76ad3aa7c5db8d481e";
const WHEEL_CID: &str = "bafkreiaqkleivw4l4cqem5s6pki5hjlb2pyswtcdygokblwiaalhosntim";
const PYPI_FIXTURE: &str = include_str!("fixtures/artifacts/pypi.json");
const EXPECTED_HTTP_ARTIFACT: &str = include_str!("fixtures/artifacts/expected_http_artifact.json");
const WHEEL_BYTES: &[u8] = include_bytes!("fixtures/artifacts/acme_widget-1.2.3-py3-none-any.whl");
const SDIST_BYTES: &[u8] = include_bytes!("fixtures/artifacts/acme_widget-1.2.3.tar.gz");
// ---------------------------------------------------------------------------
// Registry fake
// ---------------------------------------------------------------------------
#[derive(Clone)]
enum Route {
Json(Value),
Text(String),
Bytes(Vec<u8>),
}
#[derive(Default)]
struct FakeRegistry {
routes: Mutex<HashMap<String, Route>>,
calls: Mutex<Vec<String>>,
downloads: AtomicUsize,
}
impl FakeRegistry {
fn new(routes: Vec<(&str, Route)>) -> Arc<Self> {
let registry = Arc::new(Self::default());
for (url, route) in routes {
registry
.routes
.lock()
.unwrap()
.insert(url.to_owned(), route);
}
registry
}
fn calls(&self) -> Vec<String> {
self.calls.lock().unwrap().clone()
}
fn downloads(&self) -> usize {
self.downloads.load(Ordering::SeqCst)
}
fn route(&self, url: &str) -> Option<Route> {
self.routes.lock().unwrap().get(url).cloned()
}
}
#[async_trait]
impl RegistryHttp for FakeRegistry {
async fn get_json(&self, url: &str) -> anyhow::Result<Value> {
self.calls.lock().unwrap().push(format!("json {url}"));
match self.route(url) {
Some(Route::Json(value)) => Ok(value),
_ => Err(anyhow::anyhow!("unexpected JSON request {url}")),
}
}
async fn get_text(&self, url: &str) -> anyhow::Result<String> {
self.calls.lock().unwrap().push(format!("text {url}"));
match self.route(url) {
Some(Route::Text(value)) => Ok(value),
_ => Err(anyhow::anyhow!("unexpected text request {url}")),
}
}
async fn head_size(&self, url: &str) -> anyhow::Result<u64> {
self.calls.lock().unwrap().push(format!("head {url}"));
match self.route(url) {
Some(Route::Bytes(bytes)) => Ok(bytes.len() as u64),
_ => Err(anyhow::anyhow!("unexpected HEAD request {url}")),
}
}
async fn download(&self, url: &str) -> anyhow::Result<Vec<u8>> {
self.downloads.fetch_add(1, Ordering::SeqCst);
self.calls.lock().unwrap().push(format!("download {url}"));
match self.route(url) {
Some(Route::Bytes(bytes)) => Ok(bytes),
_ => Err(anyhow::anyhow!("unexpected download request {url}")),
}
}
}
fn pypi_purl() -> Purl {
parse_purl("pkg:pypi/acme-widget").expect("pypi purl")
}
fn pypi_registry() -> Arc<FakeRegistry> {
FakeRegistry::new(vec![
(
PYPI_JSON_URL,
Route::Json(serde_json::from_str(PYPI_FIXTURE).expect("pypi fixture")),
),
(WHEEL_URL, Route::Bytes(WHEEL_BYTES.to_vec())),
(SDIST_URL, Route::Bytes(SDIST_BYTES.to_vec())),
])
}
// ---------------------------------------------------------------------------
// Digest cache and verification
// ---------------------------------------------------------------------------
#[tokio::test]
async fn digest_cache_hit_skips_download() {
let http = pypi_registry();
let db = DbHandle::open_in_memory().await.expect("db");
let resolver = artifacts::ArtifactResolver::new(http.clone()).with_cache(db.clone(), REPO);
let first = resolver
.resolve(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect("first resolve");
assert_eq!(first.url, WHEEL_URL);
assert_eq!(first.file_name, "acme_widget-1.2.3-py3-none-any.whl");
assert_eq!(first.sha256, WHEEL_SHA);
assert_eq!(first.cid, WHEEL_CID);
assert_eq!(first.size, WHEEL_BYTES.len() as u64);
assert_eq!(first.mime_type, "application/zip");
assert_eq!(http.downloads(), 1);
let second = resolver
.resolve(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect("cached resolve");
assert_eq!(first, second);
assert_eq!(http.downloads(), 1, "cache hit must not download");
let row = db
.get_release_artifact(REPO, "pypi", "acme-widget", "1.2.3", WHEEL_URL)
.await
.expect("lookup")
.expect("cached row");
assert_eq!(row.sha256.as_deref(), Some(WHEEL_SHA));
assert_eq!(row.cid.as_deref(), Some(WHEEL_CID));
assert_eq!(row.size, Some(WHEEL_BYTES.len() as i64));
}
#[tokio::test]
async fn declared_digest_mismatch_is_rejected_and_not_cached() {
let http = FakeRegistry::new(vec![
(
PYPI_JSON_URL,
Route::Json(serde_json::from_str(PYPI_FIXTURE).expect("pypi fixture")),
),
(WHEEL_URL, Route::Bytes(b"tampered artifact".to_vec())),
]);
let db = DbHandle::open_in_memory().await.expect("db");
let resolver = artifacts::ArtifactResolver::new(http.clone()).with_cache(db.clone(), REPO);
let error = resolver
.resolve(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect_err("digest mismatch must fail");
let mismatch = error
.downcast_ref::<artifacts::ArtifactError>()
.expect("typed digest error");
assert!(matches!(
mismatch,
artifacts::ArtifactError::DigestMismatch { .. }
));
assert!(
db.get_release_artifact(REPO, "pypi", "acme-widget", "1.2.3", WHEEL_URL)
.await
.expect("lookup")
.is_none(),
"unverified bytes must not be cached"
);
assert!(
http.calls().contains(&format!("download {WHEEL_URL}")),
"the declared file was fetched before verification"
);
assert_eq!(http.downloads(), 1);
}
#[tokio::test]
async fn computed_digest_matches_bytes_and_cid_is_stable() {
let jar_url = "https://repo1.maven.org/maven2/com/acme/widget/2.0.0/widget-2.0.0.jar";
let metadata_url = "https://repo1.maven.org/maven2/com/acme/widget/maven-metadata.xml";
let http = FakeRegistry::new(vec![
(
metadata_url,
Route::Text(
"<metadata><versioning><versions><version>2.0.0</version>\
</versions></versioning></metadata>"
.to_owned(),
),
),
(jar_url, Route::Bytes(WHEEL_BYTES.to_vec())),
]);
let db = DbHandle::open_in_memory().await.expect("db");
let resolver = artifacts::ArtifactResolver::new(http.clone()).with_cache(db.clone(), REPO);
let purl = parse_purl("pkg:maven/com.acme/widget").expect("maven purl");
let artifact = resolver
.resolve(&purl, "2.0.0", MAX_BYTES)
.await
.expect("maven resolve");
assert_eq!(artifact.file_name, "widget-2.0.0.jar");
assert_eq!(artifact.sha256, WHEEL_SHA);
assert_eq!(artifact.cid, vuln_notif::records::cidv1_raw(WHEEL_SHA));
assert_eq!(artifact.size, WHEEL_BYTES.len() as u64);
assert_eq!(artifact.mime_type, "application/java-archive");
let again = resolver
.resolve(&purl, "2.0.0", MAX_BYTES)
.await
.expect("cached maven resolve");
assert_eq!(artifact.cid, again.cid, "CID must be stable");
}
#[tokio::test]
async fn http_artifact_record_matches_expected_fixture() {
let resolver = artifacts::ArtifactResolver::new(pypi_registry());
let resolved = resolver
.resolve(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect("resolve");
let expected: Value =
serde_json::from_str(EXPECTED_HTTP_ARTIFACT).expect("expected artifact fixture");
assert_eq!(artifacts::http_artifact_record(&resolved), expected);
}
// ---------------------------------------------------------------------------
// Multi-artifact selectors
// ---------------------------------------------------------------------------
struct SdistSelector;
#[async_trait]
impl artifacts::ArtifactSelector for SdistSelector {
async fn candidates(
&self,
_purl: &Purl,
_raw_version: &str,
) -> anyhow::Result<Vec<artifacts::ArtifactCandidate>> {
Ok(vec![artifacts::ArtifactCandidate {
file_name: "acme_widget-1.2.3.tar.gz".to_owned(),
url: SDIST_URL.to_owned(),
sha256: None,
size: Some(SDIST_BYTES.len() as u64),
mime_type: String::new(),
metadata: Value::Null,
}])
}
}
#[tokio::test]
async fn resolve_many_adds_selector_artifacts() {
let http = pypi_registry();
let resolver =
artifacts::ArtifactResolver::new(http.clone()).with_selector(Arc::new(SdistSelector));
let resolved = resolver
.resolve_many(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect("resolve many");
assert_eq!(resolved.len(), 2);
assert_eq!(resolved[0].url, WHEEL_URL);
assert_eq!(resolved[1].file_name, "acme_widget-1.2.3.tar.gz");
assert_eq!(resolved[1].sha256, SDIST_SHA);
assert_eq!(resolved[1].mime_type, "application/gzip");
assert_eq!(http.downloads(), 2);
}
// ---------------------------------------------------------------------------
// Byte caps and retries
// ---------------------------------------------------------------------------
#[tokio::test]
async fn content_length_over_cap_is_rejected_without_download_or_retry() {
let server = MockServer::start().await;
Mock::given(method("GET"))
.and(path("/big"))
.respond_with(ResponseTemplate::new(200).set_body_bytes(vec![b'x'; 64]))
.mount(&server)
.await;
let http = ReqwestRegistryHttp::new().expect("http client");
let error = http
.download_limited(&format!("{}/big", server.uri()), 32)
.await
.expect_err("Content-Length over cap");
let too_large = error
.downcast_ref::<DownloadTooLarge>()
.expect("typed size error");
assert_eq!(too_large.limit, 32);
assert_eq!(too_large.size, Some(64));
assert_eq!(server.received_requests().await.unwrap().len(), 1);
}
/// Chunked HTTP/1.1 response with no `Content-Length`, so the cap can only be
/// enforced while streaming.
async fn chunked_server(chunks: Vec<Vec<u8>>) -> String {
use tokio::io::{AsyncReadExt, AsyncWriteExt};
use tokio::net::TcpListener;
let listener = TcpListener::bind("127.0.0.1:0").await.expect("bind");
let address = listener.local_addr().expect("local address");
tokio::spawn(async move {
let (mut socket, _) = listener.accept().await.expect("accept");
let mut request = [0u8; 1024];
let _ = socket.read(&mut request).await;
let _ = socket
.write_all(
b"HTTP/1.1 200 OK\r\nContent-Type: application/octet-stream\r\n\
Transfer-Encoding: chunked\r\n\r\n",
)
.await;
for chunk in chunks {
let header = format!("{:x}\r\n", chunk.len());
let _ = socket.write_all(header.as_bytes()).await;
let _ = socket.write_all(&chunk).await;
let _ = socket.write_all(b"\r\n").await;
}
let _ = socket.write_all(b"0\r\n\r\n").await;
});
format!("http://{address}/artifact")
}
#[tokio::test]
async fn streamed_body_over_cap_is_rejected() {
let url = chunked_server(vec![b"123456".to_vec(), b"789012".to_vec()]).await;
let http = ReqwestRegistryHttp::new().expect("http client");
let error = http
.download_limited(&url, 8)
.await
.expect_err("streamed body over cap");
let too_large = error
.downcast_ref::<DownloadTooLarge>()
.expect("typed size error");
assert_eq!(too_large.limit, 8);
}
#[tokio::test]
async fn download_limited_retries_503_then_succeeds() {
let server = MockServer::start().await;
Mock::given(method("GET"))
.and(path("/artifact"))
.respond_with(ResponseTemplate::new(503))
.up_to_n_times(1)
.mount(&server)
.await;
Mock::given(method("GET"))
.and(path("/artifact"))
.respond_with(ResponseTemplate::new(200).set_body_bytes(b"payload".to_vec()))
.mount(&server)
.await;
let http = ReqwestRegistryHttp::new().expect("http client");
let bytes = http
.download_limited(&format!("{}/artifact", server.uri()), 64)
.await
.expect("retry succeeds");
assert_eq!(bytes, b"payload");
assert_eq!(server.received_requests().await.unwrap().len(), 2);
}
#[tokio::test]
async fn download_limited_does_not_retry_413() {
let server = MockServer::start().await;
Mock::given(method("GET"))
.respond_with(ResponseTemplate::new(413))
.mount(&server)
.await;
let http = ReqwestRegistryHttp::new().expect("http client");
let error = http
.download_limited(&format!("{}/artifact", server.uri()), 64)
.await
.expect_err("413 is not retried");
assert!(error.to_string().contains("413"));
assert_eq!(server.received_requests().await.unwrap().len(), 1);
}
// ---------------------------------------------------------------------------
// Mirror and blob paths
// ---------------------------------------------------------------------------
#[derive(Default)]
struct MemoryMirror {
entries: Mutex<HashMap<String, Vec<u8>>>,
}
#[async_trait]
impl artifacts::ArtifactMirror for MemoryMirror {
async fn put(&self, key: &str, bytes: &[u8]) -> anyhow::Result<()> {
self.entries
.lock()
.unwrap()
.insert(key.to_owned(), bytes.to_vec());
Ok(())
}
async fn get(&self, key: &str) -> anyhow::Result<Option<Vec<u8>>> {
Ok(self.entries.lock().unwrap().get(key).cloned())
}
}
#[tokio::test]
async fn mirror_round_trip_avoids_second_download() {
let http = pypi_registry();
let mirror = Arc::new(MemoryMirror::default());
let db = DbHandle::open_in_memory().await.expect("db");
let resolver = artifacts::ArtifactResolver::new(http.clone())
.with_cache(db, REPO)
.with_mirror(mirror.clone());
let first = resolver
.resolve(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect("first resolve");
assert_eq!(http.downloads(), 1);
let (key, mirrored) = {
let entries = mirror.entries.lock().unwrap();
assert_eq!(entries.len(), 1);
let (key, bytes) = entries.iter().next().expect("mirrored entry");
(key.clone(), bytes.clone())
};
assert_eq!(mirrored, WHEEL_BYTES);
assert_eq!(
artifacts::ArtifactMirror::get(mirror.as_ref(), &key)
.await
.expect("mirror get")
.as_deref(),
Some(WHEEL_BYTES)
);
// Fresh DB: only the mirror can satisfy this resolve.
let db = DbHandle::open_in_memory().await.expect("db");
let resolver = artifacts::ArtifactResolver::new(http.clone())
.with_cache(db, REPO)
.with_mirror(mirror);
let second = resolver
.resolve(&pypi_purl(), "1.2.3", MAX_BYTES)
.await
.expect("mirror resolve");
assert_eq!(first, second);
assert_eq!(http.downloads(), 1, "mirror supplied the bytes");
}
#[tokio::test]
async fn blob_path_gzips_and_uploads() {
let fake = common::FakePds::new();
fake.push_upload(common::response(
200,
json!({
"blob": {
"$type": "blob",
"ref": {"$link": "bafyblob"},
"mimeType": "application/gzip",
"size": 42,
}
}),
));
let time = common::FakeTime::new(0.0);
let (logger, _sink) = common::logger();
let (publisher, _governor, _db) =
common::publisher_with(fake.clone(), time, "com.nahdig.cve.nvdV2", logger).await;
let payload = b"artifact body\n";
let sha256 = vuln_notif::records::sha256_hex(payload);
let artifact = artifacts::ResolvedArtifact {
file_name: "notes.txt".to_owned(),
url: "https://example.test/notes.txt".to_owned(),
cid: vuln_notif::records::cidv1_raw(&sha256),
sha256,
size: payload.len() as u64,
mime_type: "text/plain".to_owned(),
metadata: Value::Null,
};
let record = artifacts::blob_artifact_record(&publisher, &artifact, payload, 1024)
.await
.expect("blob record");
assert_eq!(record["$type"], "software.release.defs#blobArtifact");
assert_eq!(record["fileName"], "notes.txt");
assert_eq!(record["blob"]["ref"]["$link"], "bafyblob");
let calls = fake.calls();
let upload = calls
.iter()
.find(|call| call.method == "uploadBlob")
.expect("uploadBlob call");
assert_eq!(upload.mime.as_deref(), Some("application/gzip"));
let mut decoder = flate2::read::GzDecoder::new(upload.bytes.as_deref().expect("blob bytes"));
let mut decoded = Vec::new();
decoder.read_to_end(&mut decoded).expect("gunzip");
assert_eq!(decoded, payload);
let fallback = artifacts::blob_artifact_record(&publisher, &artifact, payload, 1)
.await
.expect("http fallback");
assert_eq!(fallback["$type"], "software.release.defs#httpArtifact");
assert_eq!(fallback["url"], artifact.url);
assert_eq!(fake.count("uploadBlob"), 1, "oversized blob stays http");
}