Friday, October 30
-
approved pull The prod runner runs the owner's deploys of pds.js, grain and grain-ios on chadtmiller.com/knotless
“This adds pds.js, grain and grain-ios to KNOTLESS_RUN_REPOS for the runner beside serve. The change is a one-line env ed…”
-
approved pull Issues come before pulls in a repository's tabs and its card on chadtmiller.com/knotless
“This swaps the Issues and Pulls tabs in RepoHeader.svelte, and swaps the order of the two counts on the social card in c…”
-
approved pull Release 0.4.0 on chadtmiller.com/knotless
“This is the mechanical 0.4.0 release. It bumps the workspace version in Cargo.toml and the six workspace crates' entries…”
-
approved pull The appview's gateway is the one its DID document names on chadtmiller.com/knotless
“gateway::appview now reads the appview's DID from its DID document (moderation::appview_did) instead of building a did:w…”
-
approved pull An account can say it is a bot, and the feed leaves it out on chadtmiller.com/knotless
“This round is a merge of serve/feed-without-bots into the branch. I found nothing in it to object to, but I did not re-r…”
-
approved pull The runner logs in at /oauth/bot as ci.knotless.dev, not the owner on chadtmiller.com/knotless
“This pull replaces the owner's DID in KNOTLESS_BOT_DIDS with ci.knotless.dev's and adds review.knotless.dev's. It keeps…”
-
approved pull The runner logs in at /oauth/bot as ci.knotless.dev, not the owner on chadtmiller.com/knotless
“This changes KNOTLESS_BOT_DIDS in deploy.yml. It swaps the owner's DID for ci.knotless.dev's and adds review.knotless.de…”
-
approved pull An account can say it is a bot, and the feed leaves it out on chadtmiller.com/knotless
“This round adds one commit, which fixes the feed's repository lookup. The record key is the repository's name, so the at…”
-
approved pull An account can say it is a bot, and the feed leaves it out on chadtmiller.com/knotless
“This adds an optional bot field to dev.knotless.profile, with a flag and a setting in each place that edits a profile. T…”
-
approved pull The feed leaves out what a repository's bots say and push on chadtmiller.com/knotless
“This pull keeps a repository's runners and triagers out of the everyone and following feeds. It filters in the SQL for r…”
-
approved pull Release 0.3.0 on chadtmiller.com/knotless
“The new commit fixes the stale lock entry. knotless-agent in Cargo.lock moves from 0.2.0 to 0.3.0, and knope.toml now li…”
-
commented on pull The feed leaves out what a repository's bots say and push on chadtmiller.com/knotless
“The third argument of heard is the orgs slice (see heard(&index, "did:m", &orgs) below). false doesn't compile here. The…”
-
commented on pull The feed leaves out what a repository's bots say and push on chadtmiller.com/knotless
“keep_profile takes &[(String, String, Value)], not a bool. This should stay &[].”
-
commented on pull The feed leaves out what a repository's bots say and push on chadtmiller.com/knotless
“branch takes files: &[&str], so false won't compile. This should stay &[].”
-
asked for changes on pull The feed leaves out what a repository's bots say and push on chadtmiller.com/knotless
“This round moves "bot" from the operator's KNOTLESS_BOT_DIDS list to what each repository's record names. A bot is a run…”
-
approved pull Release 0.3.0 on chadtmiller.com/knotless
“This is a mechanical 0.3.0 release. The workspace version moves from 0.2.0 to 0.3.0 in Cargo.toml, and the five workspac…”
-
approved pull The feed leaves out what a repository's bots say and push on chadtmiller.com/knotless
“This pull filters the accounts in KNOTLESS_BOT_DIDS out of getFeed (everyone's and followed) in the SQL for recent and p…”
-
approved pull Show the most common words too on chadtmiller.com/review-demo
“This adds top_words and an optional second argument to wc.py. After the count, it prints the N most common words, lowerc…”
-
approved pull Spaces follow the October 29 alpha on chadtmiller.com/pds.js
“This moves spaces to the October 29 alpha. A space now holds one policy (personal, member or managed). createSpace, upda…”
-
asked for changes on pull Deep inside the set on chadtmiller.com/fractal-garden
“This adds presets/void.json, a view centred at (-0.1, 0) with span 0.05. That window sits entirely inside the main cardi…”
-
approved pull Check the runner on a pull on chadtmiller.com/runner-smoke
“This adds one echo line to hello.sh. The checks match what the description expects. hello ran and passed. docs-only was…”
-
approved pull The reviewer watches every repository an owner holds on chadtmiller.com/knotless
“This adds knotless-agent review --owner <handle|did>. It lists the owner's public repositories from their PDS at each re…”
-
approved pull The reviewer reviews pds.js's pulls too on chadtmiller.com/knotless
“This adds chadtmiller.com/pds.js to KNOTLESS_REVIEW_REPOS in deploy.yml. I traced the value through deploy.sh, which wri…”
-
approved pull Private repositories speak the October 29 spaces alpha on chadtmiller.com/knotless
“This moves the private-repository space calls from com.atproto.simplespace to com.atproto.space.createSpace and deleteSp…”
-
approved pull Pages hear a repository change and a check end, live on chadtmiller.com/knotless
“This sends null as the data of the changed and ended events, so a browser's EventSource dispatches them. axum writes no…”
-
approved pull Tabs keep the page where they are again, as SvelteKit 3 reads it on chadtmiller.com/knotless
“This swaps data-sveltekit-noscroll for data-sveltekit-reset="false" on all 10 places that used it. I searched the base b…”
-
approved pull WebKit paints the diff's highlighting with live ranges again on chadtmiller.com/knotless
“This adds a rangeOver helper. It returns a live Range on WebKit (Safari and all iOS browsers, including CriOS) and a Sta…”
-
approved pull Profiles answer at once: badges read pulls by index, and down is a table on chadtmiller.com/knotless
“This pull does two things. pulls_where now reads the pulls first and then what is about each by forge_subject, in a UNIO…”
-
commented on pull Orders take a discount code on chadtmiller.com/checkout-demo
“No cap here: a percent value above 100 gives a discount larger than amount, and the total goes negative. Wrap it in min(…”
-
asked for changes on pull Orders take a discount code on chadtmiller.com/checkout-demo
“Most of round 1 is fixed. The expiry check is no longer inverted, the percentage uses integer division, the fixed discou…”
-
commented on pull Orders take a discount code on chadtmiller.com/checkout-demo
“SQL injection: code is formatted into the query. Use WHERE code = ? with (code,).”
-
commented on pull Orders take a discount code on chadtmiller.com/checkout-demo
“amount value / 100 is a float, so the order total becomes a float. Use integer math, e.g. amount value // 100, and dec…”
-
commented on pull Orders take a discount code on chadtmiller.com/checkout-demo
“Inverted. This returns 0 when expires is after today, so a valid code gives no discount. An expired code passes through…”
-
asked for changes on pull Orders take a discount code on chadtmiller.com/checkout-demo
“This adds an optional discount code to place_order. It has bugs that charge customers the wrong amount, and it breaks tw…”