Saturday, October 31
-
commented on pull Mirrors keep a commit-graph, so walks of history read one file on chadtmiller.com/knotless
“A failed graph write fails the sync even though the refs are already updated and the graph is only an optimisation. Cons…”
-
approved pull Mirrors keep a commit-graph, so walks of history read one file on chadtmiller.com/knotless
“After a sync that moves a mirror's refs, or finds a mirror with no commit-graph, this runs git commit-graph write --reac…”
-
approved pull grain-serve import reads hatk's grain.db into a new index on grain.social/grain
“My earlier review asked for nothing to change, and fe819be only puts two of the summary's writes on one line each so the…”
-
approved pull grain-serve import reads hatk's grain.db into a new index on grain.social/grain
“This adds grain-serve import. It reads hatk's database read-only into a new or empty index in one transaction. It rebuil…”
-
approved pull Hosts identity data names are asked only on https, at public addresses on grain.social/grain
“This pull moves backfill's fetch policy into grain::guard and applies it to every fetch that identity data drives. Those…”
-
approved pull knotless-agent: a merge of the base into a pull spends no review round on chadtmiller.com/knotless
“This makes the reviewer carry its last verdict to a new head when git patch-id --stable of the -U0 diff from the merge b…”
-
approved pull Review headers keep the name beside the avatar, and fields stop zooming on a phone on chadtmiller.com/knotless
“This adds a --byline-min flex-basis so a review's byline stays beside the avatar. It also adds a --text-field-sm token f…”
-
approved pull The account settings tabs fade at their edges on a phone on chadtmiller.com/knotless
“This replaces SettingsPage's own scrollIntoView effect with the shared scrollRow(current) attachment. It's the same call…”
-
approved pull grain-serve backfills the index from hubble, or each account's PDS on grain.social/grain
“The blocker from rounds 1 and 2 is fixed, so I approve.”
-
commented on pull grain-serve backfills the index from hubble, or each account's PDS on grain.social/grain
“This client follows redirects and has no scheme or address policy. Fetches of DID-document-supplied PDS URLs go through…”
-
asked for changes on pull grain-serve backfills the index from hubble, or each account's PDS on grain.social/grain
“The one blocker from round 1 is still open. The PDS URL comes from the account's DID document, and getRepo is still fetc…”
-
approved pull Core reads whole repos as STAR-lite or CAR, checked as they stream on grain.social/grain
“Since my last review, the two points I raised are done. Car::read now refuses a header whose version isn't 1 (car.rs:76-…”
-
asked for changes on pull grain-serve backfills the index from hubble, or each account's PDS on grain.social/grain
“This pull adds grain_serve::backfill. It discovers accounts from the collection directories, reads each repo from hubble…”
-
approved pull Core reads whole repos as STAR-lite or CAR, checked as they stream on grain.social/grain
“The only change since my last review is a rename. Archive::next, Car::next and StarLite::next are now record(), to avoid…”
-
approved pull server: indexRecords reads a caller's new records back into the index on grain.social/grain
“The new commit only changes tests, and my earlier approval still stands. The reference PDS bundles gallery, photo and fa…”
-
approved pull Core reads whole repos as STAR-lite or CAR, checked as they stream on grain.social/grain
“This pull adds grain::repo. It reads a repo export as STAR-lite or CAR, with or without zstd. It rebuilds the MST root f…”
-
approved pull server: indexRecords reads a caller's new records back into the index on grain.social/grain
“This pull serves social.grain.sync.indexRecords. It verifies the service token with auth::verify (aud the server's did:w…”
-
approved pull server: Jetstream feeds the index, resuming where it was read to on grain.social/grain
“The pull still does what it says: a Jetstream v2 reader with backoff, ping-on-idle and the cursor probe, plus an apply t…”
-
approved pull server: An index of grain's own, its records put by URI and CID on grain.social/grain
“The new commit wraps delete in a transaction, so the self_label rows and the record row are removed together. That was m…”
-
approved pull server: Jetstream feeds the index, resuming where it was read to on grain.social/grain
“The pull still does what it says: a Jetstream v2 reader with backoff, ping-on-idle and the cursor probe, and an apply th…”
-
commented on pull server: Jetstream feeds the index, resuming where it was read to on grain.social/grain
“seq moves past this event even when apply fails, and the next save persists it. A failed write is then never retried.”
-
commented on pull server: Jetstream feeds the index, resuming where it was read to on grain.social/grain
“Clear self.seq here as well as logging. Otherwise ended() re-saves the abandoned cursor if the live connection hears not…”
-
approved pull server: Jetstream feeds the index, resuming where it was read to on grain.social/grain
“This adds a Jetstream v2 reader to grain (follow, with backoff, ping-on-idle and the cursor probe) and grain-serve appli…”
-
approved pull server: An index of grain's own, its records put by URI and CID on grain.social/grain
“The new commit changes only tests, and I found nothing that must change.”
-
commented on pull server: An index of grain's own, its records put by URI and CID on grain.social/grain
“Optional: delete runs two statements outside a transaction. Wrap them in one so a failure between them cannot leave a re…”
-
approved pull server: An index of grain's own, its records put by URI and CID on grain.social/grain
“This adds the SQLite index for grain-serve: ordered migrations, one table per collection, a put that checks the lexicon…”
-
approved pull The Rust tests run against the reference PDS, under a coverage gate on grain.social/grain
“Both points from my first review are fixed. harness/cov.json is now { "lines": 99.1, "functions": 98.4 }, so the gate ca…”
-
commented on pull The Rust tests run against the reference PDS, under a coverage gate on grain.social/grain
“Both thresholds are 0, so the gate can never fail. Set them to what the first green run reports (rounded down); AGENTS.m…”
-
asked for changes on pull The Rust tests run against the reference PDS, under a coverage gate on grain.social/grain
“This adds a reference-PDS harness, integration tests for the core, a coverage gate, lexicon answer checks and the CI wor…”
-
approved pull social.grain lexicons for every method the Rust server will serve on grain.social/grain
“This is the same pull as round 2 of the review: social.grain. copies of the unspecced methods, the dev.hatk replacements…”
-
approved pull Core logs in with OAuth, keeps sessions and checks service auth on grain.social/grain
“The only change since my last review is in the test helpers in oauth.rs. The stand-in authorization server now answers r…”
-
approved pull Core logs in with OAuth, keeps sessions and checks service auth on grain.social/grain
“The only change since my last review is in oauth::start. It now strips a leading @ from the identifier before resolving…”
-
approved pull social.grain lexicons for every method the Rust server will serve on grain.social/grain
“This pull adds social.grain. copies of the 47 unspecced methods. It also adds the dev.hatk replacements, sync.indexRecor…”
-
approved pull Core logs in with OAuth, keeps sessions and checks service auth on grain.social/grain
“This pull ports knotless's oauth, session and auth modules into grain's core. It adds PAR with PKCE and DPoP, a loopback…”
-
approved pull Core resolves identities, verifies atproto keys and calls XRPC on grain.social/grain
“The only change since my last round is in a test helper in xrpc.rs: it drops the unused Read import. My earlier review a…”
-
approved pull Core resolves identities, verifies atproto keys and calls XRPC on grain.social/grain
“This pull brings knotless's protocol modules into the grain core: keys and JWTs, handle/DID/PDS resolution with its cach…”
-
approved pull The SvelteKit app lives in web/, as knotless's does on grain.social/grain
“This moves the SvelteKit app from app/ and static/ to web/src and web/static. It repoints svelte.config.js (kit.files.sr…”
-
approved pull A Rust workspace beside the Node app, built and tested on the runner on grain.social/grain
“This adds a Cargo workspace with two crates. grain holds base32, drisl and a --version binary. grain-serve is an axum se…”
-
approved pull Builds older than the server's minimum ask to be updated on grain.social/grain-android
“This adds an UpdateGate that reads /app-version.json on every resume. It caches the last good minimum in SharedPreferenc…”
-
approved pull Builds older than the server's minimum ask to be updated on grain.social/grain-ios
“This adds a launch and foreground check of /app-version.json. If CFBundleVersion is below ios.minimumBuild, UpdateRequir…”