Sunday, November 1
-
approved pull A review's menu keeps the right of its head on a phone on chadtmiller.com/knotless
“This adds a rule to the 640px media query. On a phone, a review's head (a .boxhead that holds a .verdict) becomes a thre…”
-
approved pull Steps that run at main alone say so with on on chadtmiller.com/knotless
“This moves the main-only gates in release.yml and publish-lexicons.yml from shell ref tests to step-level on: {refs: [re…”
-
approved pull A shared step can be passed a secret under the name it asks for on chadtmiller.com/knotless
“This lets a uses step's secrets be a map from the step file's name to the workflow's name. Step::seen replaces sees, and…”
-
commented on pull ci: the workflows use knotless's shared steps on grain.social/grain
“The runner rejects this: unknown field 'on' at steps[1]. The same applies to the publish step's on at line 47. The workf…”
-
asked for changes on pull ci: the workflows use knotless's shared steps on grain.social/grain
“This pull moves the packages steps in check and test to the shared npm-ci step. It also moves the lexicon plan, wait and…”
-
approved pull Over-long gallery titles are indexed and cut, and sign-in seeds a profile on grain.social/grain
“This batches two parts. The first lets the index keep galleries whose title or description runs past maxLength, and view…”
-
approved pull Release 0.5.0 on chadtmiller.com/knotless
“This is the mechanical 0.5.0 release. It bumps the workspace version in Cargo.toml to 0.5.0. It moves the six workspace…”
-
approved pull A gallery titled past its lexicon is indexed whole and shown cut on grain.social/grain
“The only change since my last review is in a test, an_index_keeps_a_gallery_that_runs_long. The strict-refusal assertion…”
-
approved pull A web login seeds a grain profile from the account's Bluesky profile on grain.social/grain
“Since my earlier approval, the pull has one new commit. seed now returns its JoinHandle, and callback drops it, so the r…”
-
approved pull A login and a gateway's grant name knotless's own space types on chadtmiller.com/knotless
“Round 3. The new commit 346b9ed fixes docs/design/access.md:163, which now says at://<org>/space/dev.knotless.orgSpace/s…”
-
commented on pull A login and a gateway's grant name knotless's own space types on chadtmiller.com/knotless
“The code's org::SPACE_TYPE is still dev.knotless.orgSpace, so the organization's space is at://<org>/space/dev.knotless.…”
-
asked for changes on pull A login and a gateway's grant name knotless's own space types on chadtmiller.com/knotless
“Round 2. Since my approval the pull has added one commit, d9e61e8, and merged main. The commit removes the whole move ou…”
-
approved pull The pages say what to do on the page, not which command to run on chadtmiller.com/knotless
“Since my last review the pull only gained two commits, and both loosen assertions in crates/knotless-run/tests/run.rs. T…”
-
approved pull A login and a gateway's grant name knotless's own space types on chadtmiller.com/knotless
“This pull narrows the login scope and the gateway grant from space: to the two named types, dev.knotless.space and dev.k…”
-
approved pull A web login seeds a grain profile from the account's Bluesky profile on grain.social/grain
“This pull seeds a grain profile from the account's Bluesky profile in a background task after a web login. It does the w…”
-
approved pull A gallery titled past its lexicon is indexed whole and shown cut on grain.social/grain
“This pull lets the index keep galleries whose title or description is past its lexicon bound. Lexicons::validate_indexed…”
-
approved pull The pages say what to do on the page, not which command to run on chadtmiller.com/knotless
“This pull takes CLI commands out of page copy and runner-written reasons. knotless show now prints the logs command on i…”
-
approved pull server: The apps sign in at their own PDS, as grain-serve's public client on grain.social/grain
“The new head 2db06b7 is a merge of feature/rust into the branch. The one conflict was in crates/grain-serve/tests/web/mo…”
-
asked for changes on pull Usage counts slow statements, why actions failed, and crawlers by agent on chadtmiller.com/knotless
“The only change since my last review is commit bd6c2ca, which extends the usage test with crawler requests. It doesn't t…”
-
approved pull A push through the gateway reads its repository once on chadtmiller.com/knotless
“This makes pushRefs build the merge gate's view and the runner's landing check from the snapshot writer read under the p…”
-
approved pull getTemplate reads the template from the mirror, as getFile does on chadtmiller.com/knotless
“This switches getTemplate to read .knotless/<kind>.md from the serve mirror with repo.objects()?.blob(...), the way getF…”
-
asked for changes on pull Usage counts slow statements, why actions failed, and crawlers by agent on chadtmiller.com/knotless
“This pull counts slow index statements, MCP tool failures (with their messages normalized) and crawler user agents in us…”
-
approved pull Groups start on their host, apps read label definitions, serve hands on pages on grain.social/grain
“This merges four parts that were each reviewed already: the --web handoff in the deploy compose file, createGroup and ge…”
-
approved pull The pages list the shared steps repositories publish on chadtmiller.com/knotless
“This round only changes highest_first in web/steps.rs. It now calls sort_by_key instead of sort_by with a comparator. Th…”
-
approved pull The pages list the shared steps repositories publish on chadtmiller.com/knotless
“This round tidies the step pages. The version list no longer shows each version's age, so the commit link stays visible…”
-
approved pull The pages list the shared steps repositories publish on chadtmiller.com/knotless
“This round only changes wording and CSS. StepSheet now writes secrets and needs as "a, b and c" and says "Asks for the s…”
-
approved pull server: The apps sign in at their own PDS, as grain-serve's public client on grain.social/grain
“Carried forward: the change this pull makes at 5be6e69b488174e146ae15a1764fb277998ea8fd is the one reviewed at 53f53b154…”
-
approved pull The pages list the shared steps repositories publish on chadtmiller.com/knotless
“This round adds the pages on top of the index: a /steps directory with search and a per-repository filter, a step page (…”
-
approved pull The pages list the shared steps repositories publish on chadtmiller.com/knotless
“This pull indexes releases of @step/<name> packages, reads their one file from the release blobs, and keeps those that p…”
-
approved pull server: The apps sign in at their own PDS, as grain-serve's public client on grain.social/grain
“The new commit stops Web from holding its own copy of the DID. app_client_metadata now reads app.did instead, so the end…”
-
asked for changes on pull The workflows use shared steps in place of their pasted blocks on chadtmiller.com/knotless
“Nothing I asked for last round has changed. On head 7ea907e, check, test, web, docs, e2e, release, scenarios and publish…”
-
commented on pull The workflows use shared steps in place of their pasted blocks on chadtmiller.com/knotless
“This uses step makes check.yml fail to load: unknown field 'uses'. The runner has no support for it yet, and the same er…”
-
asked for changes on pull The workflows use shared steps in place of their pasted blocks on chadtmiller.com/knotless
“This pull replaces the pasted Node, npm-ci, llvm-cov, lint and wait-for-checks blocks with shared steps, pins them in .k…”
-
approved pull A group is started on grain's group host without leaving grain on grain.social/grain
“Nothing new needs changing since my approval at 4060fd1. I read only the diff from that commit to 6797ea7 and did not lo…”
-
approved pull A workflow step can run only at some refs on chadtmiller.com/knotless
“This adds on: {refs: [...]} to workflow steps and to steps in shared step files. A step is skipped unless the ref a push…”
-
approved pull server: The apps sign in at their own PDS, as grain-serve's public client on grain.social/grain
“The new commit fixes what the end-to-end test found. app_calls now escapes % as %25 before # as %23, so a did:web with a…”
-
approved pull An organization's space has a type of its own, dev.knotless.orgSpace on chadtmiller.com/knotless
“The only change since my last round is the new commit f057c0a, "Covered: a move cut off part way, and asking an organiza…”
-
approved pull A group is started on grain's group host without leaving grain on grain.social/grain
“Both points from my earlier review are done.”
-
approved pull An organization's space has a type of its own, dev.knotless.orgSpace on chadtmiller.com/knotless
“This round's only change is the new commit 0bfc496, "Clippy: a stale join record is one written now". The earlier head 1…”
-
approved pull An organization's space has a type of its own, dev.knotless.orgSpace on chadtmiller.com/knotless
“This pull gives organizations their own space type, dev.knotless.orgSpace, and moves each organization's records out of…”