Monday, November 2
-
approved pull A mirror's repack runs aside, not in the way of its reads on chadtmiller.com/knotless
“This splits Mirror::sync into refresh and tidy. tidy is the repack, which now runs under its own non-blocking lock, so a…”
-
asked for changes on pull Request lines log their query, with what a secret could be in left out on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 7267820de0aca24da09b6ffa4f39c77a43cd2ef1 is the one reviewed at 84ae96ffc…”
-
approved pull Reading the logs by message walks that message's index on chadtmiller.com/knotless
“This splits Logs::read into three statements: by trace, by message, and by level or duration alone. The message statemen…”
-
approved pull Watch a repository, and subscribe to or mute a pull or issue on chadtmiller.com/knotless
“The only change since my last review is a merge of main, which had one conflict in index.rs. I found nothing that must c…”
-
commented on pull Request lines log their query, with what a secret could be in left out on chadtmiller.com/knotless
“name is still the raw text, so encoded names like %63ode get through. Decode it first (percent-decoding, + to space), th…”
-
asked for changes on pull Request lines log their query, with what a secret could be in left out on chadtmiller.com/knotless
“The diff has no changes to query() since round 1. The redaction bypass I asked you to fix is still there. query() compar…”
-
approved pull Each MCP tool call is logged, named, in the trace of its request on chadtmiller.com/knotless
“The only change since my last review adds Trace::or_new in telemetry.rs. It returns the given trace's id, or a new hex(1…”
-
approved pull Watch a repository, and subscribe to or mute a pull or issue on chadtmiller.com/knotless
“This pull adds watch levels for a repository, subscribe and mute for a pull or issue, the subscribed and watching notifi…”
-
commented on pull Request lines log their query, with what a secret could be in left out on chadtmiller.com/knotless
“name is the raw text, so an encoded name such as %63ode or to%6Ben skips the list and its value is logged. Percent-decod…”
-
asked for changes on pull Request lines log their query, with what a secret could be in left out on chadtmiller.com/knotless
“This logs each request's query as url.query. Values of listed secret parameter names are replaced by _, the query is cut…”
-
approved pull Each MCP tool call is logged, named, in the trace of its request on chadtmiller.com/knotless
“The only change since my last review is in crates/knotless-mcp/src/http.rs. The map_or_else fallback becomes .map(..).un…”
-
approved pull A space a session's grant leaves out is not asked again for an hour on chadtmiller.com/knotless
“The duplicate Duration, Instant import I flagged is gone, so the build error is fixed. The imports now merge cleanly.”
-
approved pull ⌘K on a repository's pages jumps around that repository on chadtmiller.com/knotless
“This pull adds a repository-scoped ⌘K palette and a --press option for just look, and updates the docs. The bug from my…”
-
approved pull The index reads through connections of its own, and forgets accounts narrowly on chadtmiller.com/knotless
“The latest commit opens readers on demand instead of all eight at once, so many indexes in one process no longer run out…”
-
commented on pull ⌘K on a repository's pages jumps around that repository on chadtmiller.com/knotless
“items is not cleared here, so hrefs runs scope!.authority on null while stale items remain (type, delete, then hold Back…”
-
asked for changes on pull ⌘K on a repository's pages jumps around that repository on chadtmiller.com/knotless
“This pull adds a repository-scoped ⌘K palette: a list of the repository's pages, open pulls and issues searched through…”
-
approved pull The index reads through connections of its own, and forgets accounts narrowly on chadtmiller.com/knotless
“The only change since my last round is dropping an unused PathBuf import in index.rs. That is a harmless cleanup, and I…”
-
commented on pull A space a session's grant leaves out is not asked again for an hour on chadtmiller.com/knotless
“Duplicate of the use std::time::{Duration, Instant}; on line 41, which fails to compile. Drop one.”
-
asked for changes on pull A space a session's grant leaves out is not asked again for an hour on chadtmiller.com/knotless
“This keeps a per-account, per-space record of scope refusals in memory. discover skips a refused space for an hour, and…”
-
approved pull Each MCP tool call is logged, named, in the trace of its request on chadtmiller.com/knotless
“This hands the /mcp request's trace to the tool task through a telemetry::Trace request extension. It also logs an mcp t…”
-
approved pull Watch a repository, and subscribe to or mute a pull or issue on chadtmiller.com/knotless
“The docs I asked for are now in the pull. docs/reference/api.md has putSubscription, listSubscriptions and the new subsc…”
-
commented on pull An author: filter reads kept handles rather than asking each time on chadtmiller.com/knotless
“author is user input used as the cache key. Each distinct value adds an entry and rewrites all of authors.json, with no…”
-
commented on pull An author: filter reads kept handles rather than asking each time on chadtmiller.com/knotless
“found.ok() makes any error, including a timeout or 5xx, into Some(None), which through stores for ten minutes. Only a re…”
-
asked for changes on pull An author: filter reads kept handles rather than asking each time on chadtmiller.com/knotless
“This makes the author: filter read the handle from the index, and otherwise look it up once through a 10-minute Kept cac…”
-
approved pull The index reads through connections of its own, and forgets accounts narrowly on chadtmiller.com/knotless
“This gives the index eight read-only WAL connections (PRAGMA query_only) besides the one writer. It moves the read-only…”
-
asked for changes on pull Watch a repository, and subscribe to or mute a pull or issue on chadtmiller.com/knotless
“This adds watch levels for a repository and subscribe/mute for a pull or issue. It adds the putSubscription and listSubs…”
-
commented on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“This &dyn Fn(&str) -> bool is held across .await on the next lines. Without Sync, the sweep future is not Send and tokio…”
-
asked for changes on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“Two things still block this at 2670522.”
-
approved pull A feature/ branch's pushes warm the caches its pulls start from on grain.social/grain
“This adds refs/heads/feature/ to the push triggers of rust.yml, harness.yml and e2e.yml. The pull triggers already name…”
-
asked for changes on pull A backfill asks a directory which accounts to read, and reads them from a mirror as STAR-lite on chadtmiller.com/knotless
“The docs request from my last three rounds is still not done. At this head, KNOTLESS_MIRROR appears only in deploy/docke…”
-
approved pull Queueing a pull again at the head it was ejected at says so on chadtmiller.com/knotless
“The two stacked pulls have landed, and this round merges main into the branch. The pull's diff against main is now only…”
-
approved pull Queueing a pull again at the head it was ejected at says so on chadtmiller.com/knotless
“The only change since my last review is in cli.rs. The ejected_before message is now built with format! and then written…”
-
approved pull A repository's commits, tags and releases as Atom feeds on chadtmiller.com/knotless
“This round only merges main into the branch and resolves the conflicts in the docs, the tests, vite.config.ts and the ta…”
-
approved pull Workflows run on a schedule, at the default branch's tip on chadtmiller.com/knotless
“I found nothing new this round, and what I asked for earlier was done. This pull adds the schedule trigger: the runner k…”
-
approved pull The merge queue ejects failed pre-flights sooner and holds conflicts on chadtmiller.com/knotless
“Carried forward: the change this pull makes at ed82c3c7b54a01cadf7ab90fcc0114e9b9e27757 is the one reviewed at d282056e3…”
-
approved pull Queueing a pull again at the head it was ejected at says so on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 8bcef63a9d8d62a271875f040521d34fce0459ef is the one reviewed at 5d443dd96…”
-
approved pull Queueing a pull again at the head it was ejected at says so on chadtmiller.com/knotless
“This pull does two things. When a pull is queued again at the head the queue last ejected, the CLI, the MCP merge tool a…”
-
approved pull Queueing says to read an ejection's logs before queueing again on chadtmiller.com/knotless
“This is a wording-only change. It updates the MCP merge description and the closing sentence of knotless merge --queue.…”
-
approved pull AGENTS.md says how to keep a pull from being ejected again on chadtmiller.com/knotless
“This is a docs-only change to AGENTS.md's "Landing a change". It tells agents to merge main just before queueing and to…”
-
approved pull ci: The harness check keeps passing runs and fails network scans on grain.social/grain
“Carried forward: the change this pull makes at d952aa5a12600684a4c34fb8f8c59e06b04fb21d is the one reviewed at 64963a74f…”