Wednesday, November 4
-
asked for changes on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“The head moved from 8928687 to a885225 through a merge and two small commits. Neither fix I asked for is in, and the one…”
Tuesday, November 3
-
approved pull knotless site deploys a directory as a repository's website on chadtmiller.com/knotless
“Since my last review, the only change is in served_at in crates/knotless/src/site.rs. with_context(|| format!(..)) becam…”
-
approved pull The proxy holds knotless.page's certificate, and serve answers its sites on chadtmiller.com/knotless
“This adds an optional knotless.page block to the proxy. With KNOTLESS_PAGES_DOMAIN set, setup.sh builds Caddy with the C…”
-
approved pull A private repository's space syncs past a record that cannot be read on chadtmiller.com/knotless
“I still approve. Since my earlier review (cbd810e) the only change is in crates/knotless-serve/src/spaces.rs. whole and…”
-
approved pull A private repository's space syncs past a record that cannot be read on chadtmiller.com/knotless
“I read the whole diff but did not run it or read the checks. I find the verification argument sound, so I approve.”
-
approved pull Repositories have websites, served on knotless.page on chadtmiller.com/knotless
“At this head the pull is only the first part of the feature: the design page docs/design/pages.md, its sidebar and index…”
-
approved pull knotless site deploys a directory as a repository's website on chadtmiller.com/knotless
“Since my last review, the only change is in the sites test. It now expects the output of the deploy and --down runs with…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“name is percent-decoded, so /%5Cevil.com redirects to /\evil.com/, an open redirect. Reject or encode \ and control char…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“Still unvalidated: this temp name is built from the same sha256, so a value like ./../x creates a file outside dir.”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“Still unvalidated: file.sha256 can be ../…, so this join leaves dir and an existing file is opened and served. Check for…”
-
asked for changes on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“The head moved from 310e0e3 to 8928687, but only through merge commits. The serve code is unchanged, so nothing I asked…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“name is percent-decoded, so /%5Cevil.com redirects to /\evil.com/, which browsers treat as //evil.com. Reject or encode…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“The same unvalidated hash goes into this temp-file name, so ./../x creates a file outside dir before the hash check fail…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“file.sha256 is unvalidated record data, so this join can leave dir. With ../… as the hash, try_exists is true for any ex…”
-
asked for changes on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“This adds --pages-domain to knotless-serve. Requests on that domain, or on a name under it, are answered from dev.knotle…”
-
approved pull knotless site deploys a directory as a repository's website on chadtmiller.com/knotless
“This adds knotless site, which deploys a directory as the repository's website. It also adds the dev.knotless.site lexic…”
-
approved pull Pages are designed, with the dev.knotless.site record on chadtmiller.com/knotless
“The new commit adds a "Private sites" section to docs/design/pages.md and changes "has no site" to "has no site yet" in…”
-
approved pull Pages are designed, with the dev.knotless.site record on chadtmiller.com/knotless
“The new commit limits fallback to page requests: those that ask for text/html, or whose last path segment has no extensi…”
-
approved pull Pages are designed, with the dev.knotless.site record on chadtmiller.com/knotless
“This adds the Pages design page (in the sidebar and the design index) and the dev.knotless.site lexicon. I read all four…”
-
approved pull Merges always name their pull, and a push that lands a pull merges it on chadtmiller.com/knotless
“The only change since my last review (d86609b to 15fb30f) is in crates/knotless-serve/tests/forge.rs, in merges_wait_for…”
-
approved pull Merges always name their pull, and a push that lands a pull merges it on chadtmiller.com/knotless
“The only change since my last review (a8bc290 to d86609b) is a commit that updates tests in the mcp, forge, gateway, pri…”
-
approved pull Merges always name their pull, and a push that lands a pull merges it on chadtmiller.com/knotless
“This pull makes merge always produce a merge commit naming the pull, or a squash into a linear branch. A pull whose head…”
-
approved pull The runner host deploys with main on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 9663117a8c50da09ea18b7f5188c4206ce69a9f9 is the one reviewed at 6e8a12519…”
-
approved pull The runner host deploys with main on chadtmiller.com/knotless
“This makes main's deploy end with a runner host step. It reaches the runner host with its own key, RUNNER_HOST_SSH_KEY.…”
-
approved pull A private repository's pages no longer wait for its space to sync on chadtmiller.com/knotless
“My earlier approval stands. The only change since it is 875721e. It compares the readers to a slice of the member, as cl…”
-
approved pull The reviewer reviews group-host's pulls, a private repository named on chadtmiller.com/knotless
“This adds chadtmiller.com/group-host to KNOTLESS_REVIEW_REPOS in the deploy workflow, because --owner only lists public…”
-
approved pull Records stored cut short read again, as they did on chadtmiller.com/pds.js
“The pull restores the old lenient decoder and keeps the 8-byte integer heads. It looks correct for the stated goal, and…”
-
approved pull A private repository's pages no longer wait for its space to sync on chadtmiller.com/knotless
“My earlier approval stands. The only change since it is 57a8407. It fixes the pages test so it expects the member shared…”
-
approved pull CBOR integers of 32 bits or more are written, and what cannot be is refused on chadtmiller.com/pds.js
“The pull adds an 8-byte CBOR head (info 27) to encodeHead, so integers from 2^32 up to MAX_SAFE_INTEGER are written. Bot…”
-
approved pull A private repository's pages no longer wait for its space to sync on chadtmiller.com/knotless
“This round keeps the background sync for a stale, already-synced space. It also keeps a private repository's storage cou…”
-
approved pull A private repository's pages no longer wait for its space to sync on chadtmiller.com/knotless
“My earlier approval stands. The only change since it is 027df1f, which switches the moves and last_synced initialisers i…”
-
approved pull A private repository's pages no longer wait for its space to sync on chadtmiller.com/knotless
“This pull makes a stale but already-synced private space sync in a spawned task, so a session read answers from the inde…”
-
approved pull A private repository's readers sync it once its syncer has not lately on chadtmiller.com/knotless
“The code is unchanged in substance since my last approval. read_now still serves a stale read from the index when the re…”
-
approved pull A repository's settings no longer wait seconds for its storage on chadtmiller.com/knotless
“The only change since my earlier approval is a type alias, Counted, for the cached tuple in Counts. It is a clippy fix w…”
-
approved pull A private repository's readers sync it once its syncer has not lately on chadtmiller.com/knotless
“Both points from my earlier review are done. I couldn't run the test, since it needs the spaces alpha.”
-
commented on pull A private repository's readers sync it once its syncer has not lately on chadtmiller.com/knotless
“The doc comment of moved ("Records that the space uri was written to…") now sits above synced_now, so moved has none. Mo…”
-
commented on pull A private repository's readers sync it once its syncer has not lately on chadtmiller.com/knotless
“When synced was already true and the stale sync fails, this returns an upstream error for a read that used to succeed fr…”
-
asked for changes on pull A private repository's readers sync it once its syncer has not lately on chadtmiller.com/knotless
“This adds a last_synced map, set by the sweep and by reader syncs. A read of a private repository whose space hasn't syn…”
-
approved pull A repository's settings no longer wait seconds for its storage on chadtmiller.com/knotless
“This moves the storage count out of getRepoSettings into a new getRepoStorage query. The settings page now streams the c…”
-
approved pull Code search loads more files, 200 deep at most on chadtmiller.com/knotless
“This adds a cursor to dev.knotless.searchCode and a "More files" button to the search page, 200 files deep. I read the w…”