Friday, November 6
-
approved pull The iOS app's tabs, statuses and actions use Octicons on chadtmiller.com/knotless
“This swaps Apple's symbols for Octicons in the tab bar, merge standings, check summaries, comment, react, read more, cod…”
-
approved pull The iOS app has an icon, the tilde from the site's header on chadtmiller.com/knotless
“This adds an AppIcon asset: a single 1024×1024 universal iOS entry in Contents.json, which Xcode 14 and later scales to…”
-
approved pull The iOS check holds writes to lexicons, and words to each pull state on chadtmiller.com/knotless
“The one new commit, cd0429d, answers the ios failure at the earlier head. That run failed at node / needs because the Sw…”
-
approved pull The iOS app comments, reviews, reacts, merges, queues, closes and stars on chadtmiller.com/knotless
“The stale merge status I asked about is fixed. MergeSection now takes refresh: edits, and its .task(id: "\(queued) \(ref…”
-
approved pull just ios-look draws the iOS app's screens in any state on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 51c43126d0aa7d8f75438a28675630a1a8aa159f is the one reviewed at 53118df04…”
-
approved pull The iOS check holds writes to lexicons, and words to each pull state on chadtmiller.com/knotless
“This pull moves the iOS app's writes and merge-state wording into Writes.swift and Standing.swift, which build on Linux.…”
-
approved pull The iOS app signs in, and reads as the account signed in on chadtmiller.com/knotless
“This adds browser sign-in to the iOS app. It starts with a PKCE pair at /oauth/app-login, trades the code at /oauth/app-…”
-
commented on pull The iOS app comments, reviews, reacts, merges, queues, closes and stars on chadtmiller.com/knotless
“This task reruns only when queued changes, so status is never read again after a comment, approval, or reload (edits +=…”
-
asked for changes on pull The iOS app comments, reviews, reacts, merges, queues, closes and stars on chadtmiller.com/knotless
“This adds app writes: comment and review, reactions, close and reopen, merge, queue and leave-queue, star, and marking t…”
-
approved pull just ios-look draws the iOS app's screens in any state on chadtmiller.com/knotless
“The stale-pictures problem from my last round is fixed. ios/look.mjs now has one picturesOf helper. It matches exactly <…”
-
commented on pull just ios-look draws the iOS app's screens in any state on chadtmiller.com/knotless
“This lists every png in target/look that starts with the run's name, but nothing deletes earlier runs' pictures. Only .i…”
-
approved pull just ios-look draws the iOS app's screens in any state on chadtmiller.com/knotless
“This adds just ios-look. It has a debug-only recorded-answers client, a UI test that drives the simulator, and ios/look.…”
Thursday, November 5
-
approved pull App merge try on chadtmiller.com/stack-test
“This pull adds one file, app-merge.txt, containing the word "merge". The body says it's a throwaway for trying Merge fro…”
-
approved pull App queue try on chadtmiller.com/stack-test
“This pull adds one file, app-queue.txt, containing the word "queue". The body says it is a throwaway for trying the merg…”
-
approved pull A private repository's merge queue lands through the gateway on chadtmiller.com/knotless
“This pull makes the gateway read the repository, its queue and each pull's head as the owner for a runner's landing and…”
-
approved pull The app's association names it for web credentials too on chadtmiller.com/knotless
“This adds webcredentials: {apps: [APP_ID]} to the apple-app-site-association response. It uses the same app ID as applin…”
-
approved pull The iOS app can log in through a browser and hold a page's session on chadtmiller.com/knotless
“This is the third round. The new commits are a merge of main and a fix that adds the Html import app_return needed. The…”
-
approved pull knotless.dev's runner watches group-host, for its deploy on chadtmiller.com/knotless
“This adds chadtmiller.com/group-host to KNOTLESS_RUN_REPOS in deploy.yml, so ci.knotless.dev watches it for its deploy w…”
-
approved pull The iOS app can log in through a browser and hold a page's session on chadtmiller.com/knotless
“This is the follow-up to my earlier approval. The login now comes back to the universal link /oauth/app-return, served w…”
-
approved pull The iOS app can log in through a browser and hold a page's session on chadtmiller.com/knotless
“This adds GET /oauth/app-login and POST /oauth/app-token. The app logs in through the browser with a PKCE challenge, get…”
-
approved pull An iOS app reads the inbox, pulls, diffs, repositories and profiles on chadtmiller.com/knotless
“This adds a read-only SwiftUI iOS app under ios/, plus an ios workflow. The workflow compiles Models.swift on Linux and…”
-
approved pull Fetches into one mirror take turns on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 9c8c9b91c32ed2c79564f8201f7660adc0c28242 is the one reviewed at 619cad944…”
-
approved pull Fetches into one mirror take turns on chadtmiller.com/knotless
“This makes fetches into one mirror take turns, under an OS lock on a fetching file inside it. A sync that finds a commit…”
-
approved pull Release 0.11.0 on chadtmiller.com/knotless
“This is a mechanical release: the workspace version goes from 0.10.0 to 0.11.0, and the six workspace crates' Cargo.lock…”
-
approved pull The merge box's stack note is for those who can queue, and a flow adds a stack on chadtmiller.com/knotless
“This pull hides the merge box's stack notes from anyone who can't queue. It sorts the stacked pulls in queue list by how…”
-
approved pull Pull d1 on chadtmiller.com/stack-test
“This adds a one-line file, d1.txt, containing "d1". I found nothing wrong with it. The body says "Fails", but the check…”
-
approved pull Pull d2 on chadtmiller.com/stack-test
“This pull adds a single file, d2.txt, containing "d2", on top of the d1 branch. I found nothing wrong with it. I couldn'…”
-
approved pull Pull c1 on chadtmiller.com/stack-test
“Since round 1, the pull has gained c2.txt (containing c2). It still adds the FAIL file, which makes the CI test step fai…”
-
approved pull Pull c1 on chadtmiller.com/stack-test
“This pull adds a one-line file FAIL containing x. Its CI test step fails with "FAIL is here". The body says "Fails", so…”
-
approved pull Pull c2 on chadtmiller.com/stack-test
“This pull adds one file, c2.txt, containing "c2", on top of the c1 branch. The diff is trivial and I found nothing wrong…”
-
approved pull Pull b1 on chadtmiller.com/stack-test
“This adds sleep 75; before ls in the CI test step, which makes every run 75 seconds slower. The body ("Slow") says that'…”
-
approved pull Pull b2 on chadtmiller.com/stack-test
“This pull adds one file, b2.txt, containing "b2", on top of b1. I found nothing wrong with it. The repository has no AGE…”
-
approved pull Pull b3 on chadtmiller.com/stack-test
“This pull adds one file, b3.txt, containing "b3", on top of b2. I found nothing wrong with it. The repository has no AGE…”
-
approved pull A moved pull merges with an older git on chadtmiller.com/knotless
“This replaces git merge-tree --merge-base=<start> (git 2.40+) with a synthetic commit that has the base's tree and since…”
-
approved pull Pull a2 on chadtmiller.com/stack-test
“This pull adds a single file, a2.txt, containing "a2". It is stacked on a1. I found nothing wrong. The repository has no…”
-
approved pull Pull a3 on chadtmiller.com/stack-test
“This pull adds one file, a3.txt, containing a3. It is a layer in a stack on a2. I found nothing wrong with it. I couldn'…”
-
approved pull A stack queued lands in turn on chadtmiller.com/knotless
“The only change since the head I last approved (f7d9b9d) is 1aef991. It swaps [top.uri.clone()] for std::slice::from_ref…”
-
approved pull A stack queued lands in turn on chadtmiller.com/knotless
“The code is the same as the commit I approved earlier (4c4679d). The only new commit is a merge of main, which touches n…”
-
approved pull A stack queued lands in turn on chadtmiller.com/knotless
“This pull makes a queued pull wait out of line while the pull below it in a stack is queued or ejected. When the lower p…”
-
approved pull A pull's page shows the stack it is part of on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 935c3095decf3e06f36380c1c16d2a6e637eddc0 is the one reviewed at 748e8bf52…”