Monday, November 2
-
approved pull ci: The pages and grain-serve are checked together, end to end on grain.social/grain
“This adds an e2e workflow and a Playwright harness. It runs grain-serve and the web build together over the harness PDS,…”
-
approved pull Groups are what spaces are for: no private galleries on grain.social/grain
“My earlier reviews asked for nothing beyond confirming the checks pass. At c9b7fb4 all five checks (check, harness, lexi…”
-
approved pull The tests run against the spaces alpha, and the stock PDS only where it differs on chadtmiller.com/knotless
“This makes harness/cov.mjs run only the binaries named in COV_STOCK against the stock PDS, and every binary against the…”
-
approved pull Groups are what spaces are for: no private galleries on grain.social/grain
“Carried forward: the change this pull makes at c9bc2189920984b64b42ae58c66b4e45c83916a2 is the one reviewed at 794001166…”
-
approved pull Probe: the tests against the spaces alpha alone on chadtmiller.com/knotless
“This is round 2 of a probe that isn't meant to land. It now runs the stock PDS only for the gateway, pages, cli, spaces…”
-
approved pull Probe: the tests against the spaces alpha alone on chadtmiller.com/knotless
“This is a self-declared probe that isn't meant to land. It sets COV_NETS=spaces and COV_STORE= (no stored runs) in the t…”
-
approved pull Groups are what spaces are for: no private galleries on grain.social/grain
“My earlier review asked for nothing beyond confirming the checks pass. At 7940011 the runner still shows all five checks…”
-
approved pull A pull's test run goes against both nets at once, as a batch's does on chadtmiller.com/knotless
“This pull drops COV_NETS=${KNOTLESS_RUN_PULL:+stock} from the test workflow. A pull's run now tests against both the sto…”
-
approved pull Groups are what spaces are for: no private galleries on grain.social/grain
“This removes the private gallery surface (methods, lexicons, handlers, /private/ pages, settings rows, the space scope a…”
-
approved pull web: Groups, pools and private galleries call grain-serve's methods on grain.social/grain
“The new commit 97abdb8 moves the eight pool methods from social.grain.group.pool. to social.grain.group.. I found nothin…”
-
approved pull web: Groups, pools and private galleries call grain-serve's methods on grain.social/grain
“The new commit 427fee0 moves getSpaceSupport to social.grain.server.getSpaceSupport. That is the name grain-serve serves…”
-
approved pull Spike: the test check measures where its time goes on chadtmiller.com/knotless
“This round adds harness/exp/proc.sh, which samples every process's CPU time every 2s. The test step runs it next to the…”
-
approved pull web: Groups, pools and private galleries call grain-serve's methods on grain.social/grain
“The new commit 03a7f0e changes only the test. It now serves grain-serve with an in-memory index and a DID, as the web's…”
-
approved pull web: Groups, pools and private galleries call grain-serve's methods on grain.social/grain
“The new commit cafedc5 does what I noted last round. The pool and private gallery writes now cast only the blobs, the DI…”
-
approved pull web: Groups, pools and private galleries call grain-serve's methods on grain.social/grain
“This moves the web's 22 social.grain.unspecced. calls to the NSIDs grain-serve serves, through $lib/xrpc's query and cal…”
-
approved pull ci: Merge main into feature/rust, onto knotless's shared steps on grain.social/grain
“This merges main's shared-steps change into feature/rust. I found nothing that has to change.”
-
approved pull Spike: the test check measures where its time goes on chadtmiller.com/knotless
“This round changes how replay.sh base builds the starting tree. It used to reverse-apply the five patches. Now it delete…”
-
approved pull Spike: the test check measures where its time goes on chadtmiller.com/knotless
“This round adds EXP_SKIP_TEST, set to "1" in test.yml. It skips the test step and the answers and plans steps that read…”
-
approved pull server: A login with no Bluesky profile makes a bare grain profile on grain.social/grain
“The pull makes a login with neither a grain profile nor a Bluesky profile create a bare grain profile. The only change s…”
-
commented on pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“This relies on swiftlint-static sitting at the top level of the zip. The checks haven't run, so that is unconfirmed. If…”
-
asked for changes on pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“The debug ls -la is gone, and lint.yml now runs the swiftlint-static binary, which suits a bare Debian image. That fixes…”
-
approved pull Pulls check that the debug app builds on grain.social/grain-android
“This round removes the lint step. Lint found 8 errors on main (MissingPermission, and seven ViewModelConstructorInCompos…”
-
approved pull A sign-in with no Bluesky profile makes a bare grain profile on grain.social/grain-android
“Since my last review the only change is that the long KDoc line in ProfileSeed.kt is rewrapped, which was the nit I rais…”
-
commented on pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“Still here: remove the debug ls -la, and locate the binary with find as format.yml does rather than assuming /opt/swiftl…”
-
asked for changes on pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“This commit pins SwiftFormat to 0.62.1, the version the code is formatted with. That is a sensible fix, since 0.64.5 wou…”
-
approved pull A sign-in with no Bluesky profile makes a bare grain profile on grain.social/grain-ios
“This folds the "no Bluesky profile" case into ProfileSeed.seed. An account with neither profile now gets a bare {$type,…”
-
approved pull A sign-in with no Bluesky profile makes a bare grain profile on grain.social/grain-android
“This makes ProfileSeed follow grain-serve's whole rule. With neither a Bluesky nor a grain profile, it now creates a bar…”
-
approved pull Pulls check that the debug app builds on grain.social/grain-android
“This adds build.yml, which runs :app:assembleDebug and then :app:lintDebug on pushes to main and on pulls into it. Compa…”
-
commented on pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“Remove the debug ls -la. Also confirm the zip really holds a runnable /opt/swiftlint/swiftlint. The lint step at line 37…”
-
asked for changes on pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“The first round's checks failed because the images' entrypoints conflicted with the runner. This commit switches both wo…”
-
approved pull server: A login with no Bluesky profile makes a bare grain profile on grain.social/grain
“This makes a login with neither a grain profile nor a Bluesky profile create a bare grain profile. The bare profile hold…”
-
approved pull Pulls check that the debug app builds on grain.social/grain-android
“This adds build.yml, which runs :app:assembleDebug and then :app:lintDebug on pushes to main and on pulls into it. The i…”
-
approved pull Pulls check formatting and SwiftLint on the runner on grain.social/grain-ios
“This adds two workflows, format.yml and lint.yml. They run swiftformat Grain GrainTests --lint and swiftlint lint Grain…”
-
approved pull Spike: the test check measures where its time goes on chadtmiller.com/knotless
“This round adds a second spike commit. harness/exp/replay.sh takes the checkout back before main's last five commits to…”
-
approved pull Records in spaces are read as written, with no public-form references left on chadtmiller.com/knotless
“This removes the two short_form modules and every caller of them. Those are the client's and runner's first-write rewrit…”
-
approved pull Spike: the test check measures where its time goes on chadtmiller.com/knotless
“This spike adds measurement to the test check. It passes --timings to the build and prints the 25 slowest units. A new h…”
-
approved pull The coverage gate names the lines it counts as missed, and no others on chadtmiller.com/knotless
“This rewrites missed in harness/cov.mjs so the "Uncovered:" list matches the table. Instances of one function, a generic…”
-
approved pull The e2e world's index wait passes on the day runner minutes free up on chadtmiller.com/knotless
“This pull makes the e2e world's index wait ignore the rendered day that runner minutes free up. It does that by pulling…”
-
approved pull A private repository's records are named in full, and public-form references are moved on chadtmiller.com/knotless
“This round's only change is 00c0bc7, "The index's move counts every line it runs". It is a behaviour-preserving refactor…”
-
approved pull server: Backfill records an account's handle on grain.social/grain
“After applying a repo, backfill now looks up the account's handle through the cached identity::handle and stores it with…”