Friday, November 6
-
approved pull The iOS app's next TestFlight build is 2 on chadtmiller.com/knotless
“This changes CURRENT_PROJECT_VERSION in ios/project.yml from 1 to 2, so the next TestFlight upload doesn't reuse a build…”
-
approved pull The iOS app gets push notifications, sent by knotless-serve on chadtmiller.com/knotless
“The only change since my last review is in index.rs. The row-mapping closure in push_devices is now a named function, pu…”
-
approved pull The iOS app gets push notifications, sent by knotless-serve on chadtmiller.com/knotless
“Nothing has changed in the push code since my last review. Since then the author made a one-line fix in tests/gateway/pu…”
-
approved pull The iOS app gets push notifications, sent by knotless-serve on chadtmiller.com/knotless
“This adds registerPush and unregisterPush, a push_device table, and a 30-second round in knotless-serve. The round reuse…”
-
approved pull A feed event says where its pull or issue stands now on chadtmiller.com/knotless
“Since my approval, the pull has gained a merge of main and a fix to the_feed. The test now expects subjectState: "open"…”
-
commented on pull The iOS app folds a description by how tall it is, not how long on chadtmiller.com/knotless
“This returns true on length alone, before the measured height is read. A long body of links that draws short still folds…”
-
approved pull The iOS app folds a description by how tall it is, not how long on chadtmiller.com/knotless
“This folds a description by its measured height (more than 440pt, then shows 360pt). fixedSize comes before onGeometryCh…”
-
approved pull The iOS app lists followers and following, and a follow updates the counts on chadtmiller.com/knotless
“This adds followers and following lists to the iOS profile and bumps account.follows after a follow or unfollow, so ever…”
-
commented on pull The iOS app folds a description by how tall it is, not how long on chadtmiller.com/knotless
“The length check wins over the measured height here. A body over 2000 characters that draws short still folds and is cut…”
-
approved pull The iOS app folds a description by how tall it is, not how long on chadtmiller.com/knotless
“This folds a description by its measured height. fixedSize comes before onGeometryChange, so the height read is the full…”
-
approved pull The iOS app's folded description reads as it does opened on chadtmiller.com/knotless
“This adds .fixedSize(horizontal: false, vertical: true) before the 360pt maxHeight frame on the folded description in io…”
-
approved pull The iOS app's spaces, radii, icons and avatars are tokens on chadtmiller.com/knotless
“This pull adds Space, Radius, Icon and Size tokens to Theme.swift and switches the iOS app's padding, spacing, radii, ic…”
-
approved pull The iOS app reviews a pull from its own sheet, with roomier rows on chadtmiller.com/knotless
“This pull adds a ReviewSheet for reviewing a pull, with a Review button on the pull page and on Files changed. The Comme…”
-
approved pull Push registers with registerPush, falling back on servers without it on grain.social/grain-ios
“Carried forward: the change this pull makes at eeaa856dc2450c659e9efc1114249c5426be57d4 is the one reviewed at 9b73f8213…”
-
approved pull Builds older than the server's minimum ask to be updated on grain.social/grain-ios
“Carried forward: the change this pull makes at c5aace157361cdb74ab76243792db3b2865a80ae is the one reviewed at a90e88ce7…”
-
approved pull Push registers with registerPush, falling back on servers without it on grain.social/grain-ios
“Carried forward: the change this pull makes at 9b73f8213dfba1580fa2ad4e2a94c563e1a1d60b is the one reviewed at 68116de9d…”
-
approved pull A feed event says where its pull or issue stands now on chadtmiller.com/knotless
“This adds an optional subjectState to the opened, commented and changed feed events. The server fills it from the reposi…”
-
approved pull TestFlight builds upload on version 10 on grain.social/grain-ios
“This changes MARKETING_VERSION in project.yml from 9 to 10, and nothing else. DEVELOPMENT.md (lines 94–97) says the trai…”
-
approved pull The iOS app is ready for TestFlight on chadtmiller.com/knotless
“The README commands now use single backslashes, so they can be copied and run. That was the one thing I asked for, and i…”
-
approved pull Xcode Cloud builds on Intel, where Homebrew has no bottles on grain.social/grain-ios
“This replaces brew install in ci_post_clone.sh with pinned git-lfs and XcodeGen downloads. Each is checked against a SHA…”
-
commented on pull The iOS app is ready for TestFlight on chadtmiller.com/knotless
“The line continuation is written \\, and inside an indented code block it shows literally. Pasted into a shell, the firs…”
-
asked for changes on pull The iOS app is ready for TestFlight on chadtmiller.com/knotless
“This adds the encryption-exemption key, a privacy manifest (no tracking, no data collected, UserDefaults reason CA92.1),…”
-
approved pull A pull's header shows its repository owner's picture, whoever opened it on chadtmiller.com/knotless
“The pull is now scoped to what its title and body say, so my earlier request is met. The diff has the owner-avatar fetch…”
-
asked for changes on pull A pull's header shows its repository owner's picture, whoever opened it on chadtmiller.com/knotless
“The avatar fix itself is fine. OwnerAvatar in ThreadView.swift uses the author's picture when the author owns the reposi…”
-
approved pull An account's pulls and issues, across repositories on chadtmiller.com/knotless
“This is the same change as before: listActorItems finds the repositories an account is involved in, reads each one's ass…”
-
commented on pull The iOS app's home and search follow GitHub's, and comments take reactions on chadtmiller.com/knotless
“This RepoRef has the handle in its did field, so every repo.uri built from it (getRepo, and the writes) carries a handle…”
-
approved pull The iOS app's home and search follow GitHub's, and comments take reactions on chadtmiller.com/knotless
“This pull replaces the iOS home with My Work, Favorites and Recent. It adds a search flow (code, repositories, people, j…”
-
approved pull An account's pulls and issues, across repositories on chadtmiller.com/knotless
“This adds dev.knotless.listActorItems. It finds the repositories an account opened, is assigned or is asked to review it…”
-
approved pull The iOS app loads Markdown's pictures, colours its code, and quotes the lines a comment is on on chadtmiller.com/knotless
“This makes the iOS app load Markdown pictures, including SVG, attachments, and paths relative to the repo. It also adds…”
-
approved pull Commits in the iOS app open their diff and details on chadtmiller.com/knotless
“The new commit only changes the list rows. CommitPeople now shows who wrote a commit in a list, and shows the committer…”
-
approved pull Commits in the iOS app open their diff and details on chadtmiller.com/knotless
“The earlier issue is fixed. CommitsView in ThreadView.swift now returns the repo the server says holds the commits, fall…”
-
commented on pull Commits in the iOS app open their diff and details on chadtmiller.com/knotless
“x”
-
asked for changes on pull Commits in the iOS app open their diff and details on chadtmiller.com/knotless
“This adds a commit screen to the iOS app: Changes and Details tabs, a jump-to-file menu, and a richer CommitRow for a br…”
-
approved pull Photos post on PDSes that still require alt on grain.social/grain
“This makes every photo write carry alt, using an empty string when there is no description. That covers the create page,…”
-
commented on pull The iOS app's code view scrolls sideways rather than wrapping on chadtmiller.com/knotless
“The widest line is picked by Character count, but the width that matters is drawn width. A shorter line of Japanese or e…”
-
approved pull The iOS app's code view scrolls sideways rather than wrapping on chadtmiller.com/knotless
“This pull replaces the wrapping code view with one where each line stays on a single row. The code scrolls sideways unde…”
-
approved pull Photos post on PDSes that still require alt on grain.social/grain-android
“GalleryDraft now always writes alt, trimmed and empty when there is no description. The test now also asserts the empty…”
-
approved pull Photos post on PDSes that still require alt on grain.social/grain-ios
“This makes GalleryDraft.writes() always set alt on social.grain.photo records, using an empty string when there is no de…”
-
approved pull Photos post on PDSes that still require alt on grain.social/grain
“This makes every social.grain.photo write send alt, as an empty string when there is no description. That covers create,…”
-
approved pull The iOS app's repository and profile screens follow GitHub's on chadtmiller.com/knotless
“This pull reworks the iOS repository and profile screens to follow GitHub's layout. It adds Commits, Releases, Actions a…”