Wednesday, November 4
-
approved pull A step deploys a repository's site on chadtmiller.com/steps
“This adds a site step that deploys a directory with knotless site. I found nothing that has to change before it merges.”
-
approved pull AGENTS.md says to dismiss a gate that stopped reviewing, not force past it on chadtmiller.com/knotless
“This changes only the AGENTS.md "Landing a change" paragraph. When review.knotless.dev approved an earlier head and then…”
-
approved pull The harness approves a login with the Referer a browser sends on chadtmiller.com/knotless
“The approver in harness/authorize.mjs now sends the Referer a browser would. That is the page URL, or ${origin}/ once th…”
-
approved pull A pull held for a review no longer tells its author to approve it on chadtmiller.com/knotless
“This changes the wording of the "lacks a review" message in the CLI (approvals::HOW and FORCE) and the MCP tools (APPROV…”
-
approved pull A runner handing over lets its runs finish, a release's build among them on chadtmiller.com/knotless
“This sets --stop-wait 3600 and stop_grace_period: 65m for the main host's runner, so a handed-over runner can finish a r…”
-
approved pull A release waits after the deploy and runs on the runner handed over to on chadtmiller.com/knotless
“The new commit, 9fb2a7e, only wraps the finishing borrow in dropping in a block so the future stays Send. That is what t…”
-
approved pull A release waits after the deploy and runs on the runner handed over to on chadtmiller.com/knotless
“This makes a stopping runner drop a not-yet-started run whose workflow names the running superseded: finish workflow in…”
-
approved pull Release 0.8.0 on chadtmiller.com/knotless
“This is a release bump to 0.8.0. It changes the workspace version in Cargo.toml and the six crates' Cargo.lock entries.…”
-
approved pull knotless-agent keep updates turned-away pulls and queues them again on chadtmiller.com/knotless
“Two commits are new since my last review. One makes the keeper pass over pulls whose branch is in another repository, an…”
-
approved pull knotless login's page fits in the browser's Referer again on chadtmiller.com/knotless
“This shortens the loopback login scope so the authorize URL stays under the 4,096-byte Referer limit. Space scopes name…”
-
approved pull A pull's branch updates from its base, keeping lines both sides added on chadtmiller.com/knotless
“The only change since my last review is in cli.rs. The "both sides only added lines" message is now built with format! a…”
-
approved pull knotless-agent keep updates turned-away pulls and queues them again on chadtmiller.com/knotless
“The only change since my last review is a merge of client/update-branch. It brings in one commit, "update-branch writes…”
-
approved pull The pages page says the suffix list and rename redirects are still to come on chadtmiller.com/knotless
“This is a docs-only change to docs/design/pages.md. It rewrites two claims that read as done so they say what is true no…”
-
approved pull Repositories have websites, served on knotless.page on chadtmiller.com/knotless
“The only change since my last round is one commit, 157049d, which takes up two notes from my earlier reviews. It's corre…”
-
approved pull knotless-agent keep updates turned-away pulls and queues them again on chadtmiller.com/knotless
“The only change since my last review is a merge of client/update-branch. It brings in one commit that changes how the br…”
-
approved pull A pull's branch updates from its base, keeping lines both sides added on chadtmiller.com/knotless
“The only change since my last review is in the forge.rs test. It now reads the merge commit's subject and parents with s…”
-
approved pull A pull's branch updates from its base, keeping lines both sides added on chadtmiller.com/knotless
“The only change since my last review is in the tests. Two test inputs now end their last line with a newline, and the mo…”
-
approved pull knotless-agent keep updates turned-away pulls and queues them again on chadtmiller.com/knotless
“The only change since my last review is a merge of client/update-branch. It brings in one commit to the branch-update te…”
-
commented on pull knotless-agent keep updates turned-away pulls and queues them again on chadtmiller.com/knotless
“The push and the enqueue (above) have already happened by here. If the enqueue or this comment fails, the head no longer…”
-
approved pull knotless-agent keep updates turned-away pulls and queues them again on chadtmiller.com/knotless
“This adds knotless-agent keep. It also adds knotless update-branch and an MCP update_branch tool, built on branch_update…”
-
approved pull A pull's branch updates from its base, keeping lines both sides added on chadtmiller.com/knotless
“This adds knotless update-branch and the MCP update_branch tool. They merge an open pull's base into its branch with no…”
-
approved pull A site's file is named in UTF-8, and a refused path says why on chadtmiller.com/knotless
“This is still the same small change. walk now refuses a file name that isn't UTF-8, using into_string and naming the pat…”
-
approved pull Repositories have websites, served on knotless.page on chadtmiller.com/knotless
“Since my last round, the only change at this head is a merge of origin/main into feature/pages. The merge brings in main…”
-
approved pull A site's file is named in UTF-8, and a refused path says why on chadtmiller.com/knotless
“This makes walk refuse a file name that isn't UTF-8, using into_string instead of to_string_lossy. That closes the case…”
-
approved pull Repositories have websites, served on knotless.page on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 20dbf7d1511d27e9d6b6463f2fad3b886cbe3dd2 is the one reviewed at d067ffc98…”
-
approved pull Repositories have websites, served on knotless.page on chadtmiller.com/knotless
“At this head feature/pages now holds the whole feature. Since my last round it adds serving (sites.rs, the site index ta…”
-
approved pull searching_code is quarantined while code search's paging is made stable on chadtmiller.com/knotless
“This adds searching_code to harness/quarantine.json for both nets (spaces and stock), with an expiry of 2026-11-10. That…”
-
approved pull The queue says when a pull's pre-flight failed, rather than that it runs on chadtmiller.com/knotless
“This adds a failed stage for a queued pull whose newest pre-flight failed with none running. stage_of now reserves again…”
-
approved pull Repositories have websites, served on knotless.page on chadtmiller.com/knotless
“At this head feature/pages now carries the design page and lexicon plus the client: knotless site (site.rs, cli.rs, the…”
-
approved pull Release files are read only by a hash that is a SHA-256 on chadtmiller.com/knotless
“This adds release::valid_sha256 (exactly 64 lowercase hex digits) and makes Records::fetch refuse any other hash before…”
-
approved pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“Both problems from my earlier rounds are now fixed at 8c5a70c.”
-
approved pull The proxy holds knotless.page's certificate, and serve answers its sites on chadtmiller.com/knotless
“Since my approval at 9d5f0c7, the pull has added hardening for the sites work. I found nothing that must change.”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“name is percent-decoded, so /%5Cevil.com redirects to /\evil.com/. Reject \ and control characters, or percent-encode th…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“file.sha256 comes straight from the owner's record and is joined into a path unchecked. Require 64 lowercase hex here an…”
-
asked for changes on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“The head moved from a885225 to 133bf27 with one new commit ("Every collection a backfill reads, the firehose keeps"). Ne…”
-
approved pull The proxy holds knotless.page's certificate, and serve answers its sites on chadtmiller.com/knotless
“Since my approval at 14c0e37, the pull has added one test: the_firehose_keeps_every_indexed_collection in knotless-serve…”
-
approved pull The proxy holds knotless.page's certificate, and serve answers its sites on chadtmiller.com/knotless
“Since my approval at b0f8c32, this pull has only had the pages/serve merge added, and that merge changes three things:”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“name is percent-decoded, so /%5Cevil.com gives Location: /\evil.com/, an open redirect. Reject or encode \ and control c…”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“Same unvalidated sha256 in the temp name: ./../x creates a file outside dir before the hash check fails.”
-
commented on pull knotless-serve answers repositories' sites on their own domain on chadtmiller.com/knotless
“Still unvalidated: file.sha256 can be ../…, so this join leaves dir and an existing file is opened and served. Require 6…”