Thursday, November 5
-
commented on pull A pull's page shows the stack it is part of on chadtmiller.com/knotless
“These two lines were ThreadView's doc comment. They now attach to StackView, and ThreadView loses its comment. Put the s…”
-
approved pull A pull's page shows the stack it is part of on chadtmiller.com/knotless
“This pull adds stack_of, which follows the chain through the open pull whose branch a pull targets and through the pull…”
-
approved pull Pulls based on a pull's branch move when it lands on chadtmiller.com/knotless
“The only change since my last round is in the forks_pulls_reviews_and_merges test in forge.rs. The test failed at de07da…”
-
approved pull Pulls based on a pull's branch move when it lands on chadtmiller.com/knotless
“The only change since my last round is in pull_range in web.rs. An error from forge::since_of is now mapped with not_fou…”
-
approved pull Pulls based on a pull's branch move when it lands on chadtmiller.com/knotless
“The only change since my last round is a one-line edit in since_at. It calls git.output_of(&args) in place of git.output…”
-
approved pull Pulls based on a pull's branch move when it lands on chadtmiller.com/knotless
“This pull moves open pulls based on a landed pull's branch onto that pull's target. It records since (the lower head) so…”
-
approved pull Release 0.10.0 on chadtmiller.com/knotless
“This is a mechanical release of 0.10.0. It bumps the workspace version in Cargo.toml, moves the six workspace crates' Ca…”
Wednesday, November 4
-
approved pull A repository's page shows its website, and what it was deployed from on chadtmiller.com/knotless
“The new commit moves the owner-label logic into site::owner_label. Repo::site in web.rs and served_at in site.rs now sha…”
-
approved pull A repository's page shows its website, and what it was deployed from on chadtmiller.com/knotless
“The new commit makes Repo::site read from indexed(app, self). A private repository's site now comes from the spaces inde…”
-
approved pull A repository's page shows its website, and what it was deployed from on chadtmiller.com/knotless
“My earlier note was about a check link that went missing when a site had no commit. The new commit drops the check link…”
-
commented on pull A repository's page shows its website, and what it was deployed from on chadtmiller.com/knotless
“A site with a check but no commit drops the check link: it only renders inside the {#if site.commit} branch. This is fin…”
-
approved pull A repository's page shows its website, and what it was deployed from on chadtmiller.com/knotless
“This adds an optional site (siteView) to getRepo's repoViewDetailed. serve reads it from the index and only sets it once…”
-
approved pull Revert "A Cloudflare PDS reaches Workers on its own account through service bindings" on chadtmiller.com/pds.js
“This is a clean revert of the service-bindings pull. It removes createBoundFetch, the PDS_FETCH_BINDINGS typedef, the do…”
-
approved pull A Cloudflare PDS reaches Workers on its own account through service bindings on chadtmiller.com/pds.js
“This adds createBoundFetch, which sends the hosts named in PDS_FETCH_BINDINGS to their service bindings and everything e…”
-
approved pull A space scope that names its type alone is granted the type's collections on chadtmiller.com/pds.js
“This resolves bare space: types through the lexicon resolver at PAR and on the direct path. It keeps the declared collec…”
-
approved pull A space scope that names its type alone is granted the type's collections on chadtmiller.com/pds.js
“This resolves the lexicon for each bare space:<type> scope at PAR and on the direct authorize path. It refuses unresolva…”
-
approved pull A check's picture opens at full size rather than on a 404 page on chadtmiller.com/knotless
“This adds data-sveltekit-reload to the check picture link in RunImages.svelte, so the browser requests the server's /xrp…”
-
approved pull Private repositories have sites, read by their members alone on chadtmiller.com/knotless
“The only change since my last review is a small refactor in index.rs. The inline row closure in the private repository l…”
-
approved pull Private repositories have sites, read by their members alone on chadtmiller.com/knotless
“This round adds a merge of main and one commit on top of the approved head. The commit updates two tests for the new fea…”
-
approved pull Docs say how a code search orders files scored alike on chadtmiller.com/knotless
“This is a docs-only change. It rewords the searchCode ordering sentence in api.md. It also adds a note to serve.md sayin…”
-
approved pull A code search's pages go on from the one before on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 5387c29bc5cf1027b9c25b549f3505742b2f2344 is the one reviewed at b8c78063e…”
-
approved pull Private repositories have sites, read by their members alone on chadtmiller.com/knotless
“This pull lets knotless repo site deploy a private repository's site into its space. serve then answers that site at <ke…”
-
approved pull A code search's pages go on from the one before on chadtmiller.com/knotless
“This makes every code-search page ask Zoekt for the same 200 files. It sorts them by score, then repository, then path,…”
-
approved pull The owner cancels a ref's or a pull's runs on chadtmiller.com/knotless
“I could not read the full diff (53 KB, saved to a file I did not open), so I reviewed from the pull body and AGENTS.md.…”
-
approved pull Two serve tests wait for the index and the code shards to settle on chadtmiller.com/knotless
“This makes two flaky tests wait for their state instead of asserting it at once. In private_repositories_indexed_here th…”
-
approved pull Workflows call knotless by its grouped names on chadtmiller.com/knotless
“This renames the five old command calls in deploy.yml and release.yml to their grouped names: repo refs, release list (t…”
-
approved pull A copy of a repository shows its commits' authors as the original does on chadtmiller.com/knotless
“The only change since my last review is the third commit. It restructures walk_authors in web.rs to drop its early retur…”
-
approved pull A copy of a repository shows its commits' authors as the original does on chadtmiller.com/knotless
“The only change since my last review is the second commit, which edits a_copy_shows_whom_the_original_vouched_for so it…”
-
approved pull A copy of a repository shows its commits' authors as the original does on chadtmiller.com/knotless
“This pull adds a background walk of each public repository's default branch. The walk records, in a new commit_author ta…”
-
approved pull Commands are grouped, and each MCP tool is its command's twin on chadtmiller.com/knotless
“The merge with main is done: the checks on 37a0b22 now run against base 6bfa560, so the publish-lexicons.yml conflict I…”
-
asked for changes on pull Commands are grouped, and each MCP tool is its command's twin on chadtmiller.com/knotless
“Main has moved again and the pull conflicts with it, so no check has run on 2aaeb09. Every workflow (check, test, docs,…”
-
approved pull Commands are grouped, and each MCP tool is its command's twin on chadtmiller.com/knotless
“The bug I raised last round is fixed. In command (crates/knotless/src/cli.rs), the action is now read only when group is…”
-
approved pull Release 0.9.0 on chadtmiller.com/knotless
“This is the 0.9.0 release commit. It bumps the workspace version in Cargo.toml and the six workspace crates' Cargo.lock…”
-
commented on pull Commands are grouped, and each MCP tool is its command's twin on chadtmiller.com/knotless
“args.rest.next() runs before .filter, so for a non-group command (login, logout, upgrade, status) the first argument is…”
-
asked for changes on pull Commands are grouped, and each MCP tool is its command's twin on chadtmiller.com/knotless
“The merge with main is done and the pull is clean, so the conflict I raised last round is fixed. The checks now show a r…”
-
asked for changes on pull Commands are grouped, and each MCP tool is its command's twin on chadtmiller.com/knotless
“This pull regroups the CLI as knotless <group> <action>, renames the MCP tools to match, keeps the old command names thr…”
-
approved pull A line's number marks the whole line in place, and shift marks a range on chadtmiller.com/knotless
“This replaces the text-only target highlight with a band across the whole row. Clicking a line number now sets the hash…”
-
approved pull The sites test takes a site down by its repository, its record and its owner on chadtmiller.com/knotless
“This extends the sites test so it takes the live site down by its repository, its dev.knotless.site record and its owner…”
-
approved pull Deploy, release and publish-lexicons wait for main's checks holding no job on chadtmiller.com/knotless
“This moves deploy, release and publish-lexicons from waiting for main's seven checks in a step to naming them in after.…”
-
approved pull A guide shows how to deploy a repository's site on chadtmiller.com/knotless
“This adds docs/guide/sites.md and links it from the docs index, the docs-site sidebar and the pages design page. I check…”