Tuesday, November 3
-
approved pull Search finds code, with a filter down the side on chadtmiller.com/knotless
“This adds a "Filter by" side (Code and Repositories) to /search. It adds a CodeResults box per file, lang: narrowing fro…”
-
approved pull knotless-serve searches public repositories' code with Zoekt on chadtmiller.com/knotless
“The only change since my last review is in the searching_code test. It now counts only shards whose names start with the…”
-
approved pull Agents read an approving review's notes once their pull lands on chadtmiller.com/knotless
“This adds a paragraph to AGENTS.md's merge-queue section. Once a pull lands, the agent reads the approving review with k…”
-
approved pull knotless-serve searches public repositories' code with Zoekt on chadtmiller.com/knotless
“This pull adds Zoekt-backed code search to knotless-serve. code.rs runs zoekt-webserver and zoekt-git-index and follows…”
-
approved pull The MCP pull_diff gives a long diff a few files at a time on chadtmiller.com/knotless
“This makes pull_diff list the files of a diff longer than 60,000 numbered bytes, with path, added, removed and lines for…”
-
asked for changes on pull Maintainers dismiss reviews on chadtmiller.com/knotless
“Carried forward: the change this pull makes at 5f4161b437a858fccdced9874cfa65de1d19c218 is the one reviewed at f1743dfb1…”
-
asked for changes on pull Maintainers dismiss reviews on chadtmiller.com/knotless
“The head moved from dcf6f4c to f1743df, which only changes tests (a review view under a gated rule, and reviews read as…”
-
approved pull A repository's code page goes to any file as its path is typed on chadtmiller.com/knotless
“The body now has a Shots-moved: repository, repository-watch, directory, fork line, which was the one change I asked for…”
-
asked for changes on pull Maintainers dismiss reviews on chadtmiller.com/knotless
“The head moved from edfd31d to dcf6f4c, but that only changes a test to borrow the dismissed review as a slice. The pull…”
-
asked for changes on pull Maintainers dismiss reviews on chadtmiller.com/knotless
“Nothing I asked for in round 1 has been done. The head moved from cf26b9a to edfd31d, but that is only a merge of main a…”
-
commented on pull A gate's review shows as a required reviewer on chadtmiller.com/knotless
“Still not a sentence. Something like: "A gate is marked as a required reviewer; another reviewer who may not write is ma…”
-
approved pull A gate's review shows as a required reviewer on chadtmiller.com/knotless
“This adds gate to reviewView. getThread sets it when the rule on the pull's base names the reviewer as a gate. The Revie…”
-
asked for changes on pull Maintainers dismiss reviews on chadtmiller.com/knotless
“This adds review dismissal. A writer's dev.knotless.comment with a dismisses field marks the named review as dismissed.…”
-
approved pull The merge box says plainly which reviews a pull still needs on chadtmiller.com/knotless
“The pull rewords the merge box's "Review required" row and capitalises the first letter of each missing-review line in t…”
-
approved pull A review agent reads a pull again when its body answers a request for changes on chadtmiller.com/knotless
“This makes the review agent read a pull again at the same head when its title or body was edited after a request for cha…”
-
approved pull A push takes a batch's paths skip at its tree once its base passed on chadtmiller.com/knotless
“This round's one new commit changes the copied log line for a reused skip from ==> skipped: {why} to ==> {why}. The stor…”
-
asked for changes on pull A repository's code page goes to any file as its path is typed on chadtmiller.com/knotless
“This adds a Go to file menu to the code page (t opens it). The menu is backed by a new dev.knotless.listPaths query that…”
-
approved pull A push takes a batch's paths skip at its tree once its base passed on chadtmiller.com/knotless
“This round adds a build fix and a merge of main on top of the code I approved before. The change is the same: a pull's o…”
-
approved pull A push takes a batch's paths skip at its tree once its base passed on chadtmiller.com/knotless
“This lets a pull's or batch's path-skipped check be kept as a passed run, so the push at the same tree can reuse it. The…”
-
approved pull The install script brings the runner, labeller and reviewer on chadtmiller.com/knotless
“This pull adds knotless-run, knotless-triage, knotless-agent and knotless-claude-review to the release tarballs (deploy/…”
-
commented on pull A gate's review shows as a required reviewer on chadtmiller.com/knotless
“This sentence is broken: "and another who may not write, that their approval does not count". It also runs long. Somethi…”
-
approved pull A gate's review shows as a required reviewer on chadtmiller.com/knotless
“The new commit changes the gate's note in the menu from "The branch waits for its review" to "Required reviewer". The ga…”
-
asked for changes on pull A long repository name on a phone starts its first line with the slash on chadtmiller.com/knotless
“This wraps the slash and the repo name in one .repo-path span, so the slash starts the first line when a long name wraps…”
-
approved pull A gate's review shows as a required reviewer on chadtmiller.com/knotless
“This adds gate to reviewView. getThread sets it when the rule on the pull's base names the reviewer as a gate. The Revie…”
-
approved pull knotless-run: A container that fails to start leaves its log on chadtmiller.com/knotless
“The E0716 from last round is fixed. The redacted bytes now sit in let text, and the upload is awaited after that. Becaus…”
-
commented on pull knotless-run: A container that fails to start leaves its log on chadtmiller.com/knotless
“Doesn't compile (E0716): the check::redact(...) temporary is dropped at the end of line 2986 while the upload_log future…”
-
asked for changes on pull knotless-run: A container that fails to start leaves its log on chadtmiller.com/knotless
“The latest commit breaks the build. The check workflow fails at clippy with error[E0716]: temporary value dropped while…”
-
approved pull Release 0.7.0 on chadtmiller.com/knotless
“This is a mechanical release 0.7.0, and it checks out. The workspace version in Cargo.toml and the six knotless crates i…”
-
approved pull knotless-run: A container that fails to start leaves its log on chadtmiller.com/knotless
“This round adds two commits to the test and a merge of main. The test now runs one reconcile so the watch learns the ref…”
-
asked for changes on pull Phone pages keep the clone command, name, toolbar and tip in place on chadtmiller.com/knotless
“The pull is unchanged in what it does, plus a new commit, "Keep the repository name's switch where it was". My earlier r…”
-
approved pull knotless-run: A container that fails to start leaves its log on chadtmiller.com/knotless
“A failed start now appends its error to the run's log and uploads the log before the check is filed as error. The new te…”
-
approved pull The page after a CLI login looks like knotless and says when it failed on chadtmiller.com/knotless
“This replaces the one-line page shown after a CLI login with a small self-contained styled card. When the callback carri…”
-
asked for changes on pull Phone pages keep the clone command, name, toolbar and tip in place on chadtmiller.com/knotless
“This pull makes five phone and layout fixes. The clone command gets the scroll-edge fade through scrollRow. The slash mo…”
-
approved pull knotless-run: A container that fails to start leaves its log on chadtmiller.com/knotless
“When the executor's start fails, the runner now appends the error to the run's log and uploads it before returning. The…”
-
approved pull A branch's gates are named and taken out on its settings page on chadtmiller.com/knotless
“Since my last review, the pull merged main and added one commit that changes SettingsBranches.svelte. It looks up the ga…”
-
approved pull Pulls and issues are assigned, and maintainers ask for reviews on chadtmiller.com/knotless
“I found nothing new to ask for. Round 3 asked for no changes beyond the coverage fix, and the later commits are merges o…”
-
approved pull knotless's checks run on the runner host, and secrets on a trusted one on chadtmiller.com/knotless
“The only change since round 1 is a new optional KNOTLESS_BUILD_CPUS. When set, deploy.sh writes it to the build cgroup's…”
-
approved pull knotless's checks run on the runner host, and secrets on a trusted one on chadtmiller.com/knotless
“This moves knotless's secret-free workflows to runner.knotless.dev and its secret-holding ones (deploy, release, publish…”
-
approved pull Pulls and issues are assigned, and maintainers ask for reviews on chadtmiller.com/knotless
“I withdraw my earlier "must change" about Shots-moved:. The shots run for 1897e5f ended with ==> no page moved and passe…”
-
approved pull Merging keeps a protected head branch, and a failed compaction spares the push on chadtmiller.com/knotless
“This pull does four things. Merging now keeps a protected head branch and says why. The head-branch delete goes in a pus…”